David Christle created FLINK-30751: -------------------------------------- Summary: Remove references to disableDataSync in RocksDB documentation Key: FLINK-30751 URL: https://issues.apache.org/jira/browse/FLINK-30751 Project: Flink Issue Type: Bug Components: Documentation Affects Versions: 1.16.0 Reporter: David Christle
The EmbeddedRocksDBStateBackend allows configuration using some predefined options via the .setPredefinedOptions method. The documentation for PredefinedOptions ([link|https://nightlies.apache.org/flink/flink-docs-master/api/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.html]) mentions setDataSync is called for {{FLASH_SSD_OPTIMIZED}} and {{SPINNING_DISK_OPTIMIZED}}. But this option was removed several years ago in RocksDB 5.3.0 ([link|https://github.com/facebook/rocksdb/blob/main/HISTORY.md#530-2017-03-08]), and according to the code [PredefinedOptions.java|https://github.com/apache/flink/blob/0bbc7b1e9fed89b8c3e8ec67b7b0dad5999c2c01/flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/PredefinedOptions.java#L72], it is no longer actually set in Flink. We should remove references to disableDataSync in PredefinedOptions.java, and in state_backend.py, so that it does not appear in the documentation. -- This message was sent by Atlassian Jira (v8.20.10#820010)