+1 for the proposal Best, Lijie
Martijn Visser <martijnvis...@apache.org> 于2023年1月17日周二 21:54写道： > Hi Yun Tang, > > +1 for the proposal. Thanks for driving this. > > Best regards, > > Martijn > > Op ma 16 jan. 2023 om 12:29 schreef Yanfei Lei <fredia...@gmail.com>: > > > Hi Yun, > > > > Thanks for kicking off this discussion, +1 for the proposal. > > In the past, we occasionally encountered flink-benchmarks compilation > > failures caused by the code updates in flink repo, like FLINK-28931[1]. > > Managing the flink-benchmarks repository by release branch can help us > > handle these cases better. > > > > [1] https://issues.apache.org/jira/browse/FLINK-28931 > > > > Best, > > Yanfei > > > > Qingsheng Ren <renqs...@gmail.com> 于2023年1月16日周一 16:27写道： > > > > > > > > Thanks for the proposal, Yun! > > > > > > +1 for managing the flink-benchmark repository by branch. I didn't put > my > > > eyes on the benchmark repo a lot but having only one branch for testing > > > multiple Flink versions requires a lot of adaptive code I assume. Also > > this > > > will make it easier to compare performance between different Flink > > > versions. > > > > > > We can start from 1.17 and cut a new branch in flink-benchmarks every > > time > > > before releasing. > > > > > > Best, > > > Qingsheng > > > > > > On Mon, Jan 16, 2023 at 1:02 PM Yun Tang <myas...@live.com> wrote: > > > > > > > Hi all, > > > > > > > > More than two years ago, we migrated the flink-benchmarks repo under > > > > apache project[1]. And we planned to make the flink-benchmarks repo > > could > > > > align with different versions of Flink. > > > > However, I somehow forget to make this done finally[2]. Thus, we > still > > > > cannot build the master branch of flink-benchmarks against flink-1.13 > > due > > > > to some incompatible changes, e.g we have removed the scala suffix of > > many > > > > modules in Flink-1.15. > > > > The release-1.17 feature freeze date is near and I think we can > > continue > > > > this work to add steps to checkout the CURRENT_SNAPSHOT_VERSION > branch > > of > > > > the flink-benchmarks repo in the release documentation[3] just like > > current > > > > what we did in flink-docker repo. Since the original discussion is > > launched > > > > more than two years ago, I think it's better to launch another > > discussion > > > > email and cc all flink-1.17 release managers. > > > > > > > > > > > > Best > > > > Yun Tang > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-17280 > > > > [2] > > > > > > > > > https://issues.apache.org/jira/browse/FLINK-16850?focusedCommentId=17202288&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17202288 > > > > [3] > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release > > > > > > > > > > > > > > >
