Hi Yuxin, Thanks for proposing the FLIP!
The motivation section makes sense. But it seems that the proposed change section mixes the proposed config with the evaluation results. It is a bit hard to understand what configs are proposed and how to describe these configs to users. Given that the configuration setting is part of public interfaces, it might be helpful to add a dedicated public interface section to describe the config key and config semantics, as suggested in the FLIP template here <https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals> . This FLIP seems to add more configs without removing any config from Flink. Intuitively this can make the Flink configuration harder rather than simpler. Maybe we can get a better idea after we add a public interface section to clarify those configs. Thanks, Dong On Mon, Dec 19, 2022 at 3:36 PM Yuxin Tan <tanyuxinw...@gmail.com> wrote: > Hi, devs, > > I'd like to start a discussion about FLIP-266: Simplify network memory > configurations for TaskManager[1]. > > When using Flink, users may encounter the following issues that affect > usability. > 1. The job may fail with an "Insufficient number of network buffers" > exception. > 2. Flink network memory size adjustment is complex. > When encountering these issues, users can solve some problems by adding or > adjusting parameters. However, multiple memory config options should be > changed. The config option adjustment requires understanding the detailed > internal implementation, which is impractical for most users. > > To simplify network memory configurations for TaskManager and improve Flink > usability, this FLIP proposed some optimization solutions for the issues. > > Looking forward to your feedback. > > [1] > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-266%3A+Simplify+network+memory+configurations+for+TaskManager > > Best regards, > Yuxin >
