Hi Martijn, +1 Thank you for bringing this up. Regarding the temporal table join, three related bugs were recently discovered, all causing data correctness issues, including: https://issues.apache.org/jira/browse/FLINK-29781 (merged & picked) https://issues.apache.org/jira/browse/FLINK-28988 (merged) https://issues.apache.org/jira/browse/FLINK-29849 (reviewing, may take another two or three days)
Hitting any of them could lead to wrong results for the user, and from this point of view we had to fix them in 1.16.1, but because of the changes involved in the planner rules, it inevitably leads to changes in the related query plan, which could lead to incompatible state for bugfix versions, which seems to be in conflict with the compatibility rules we want to implement. However, I still want these fixes added to 1.16.1 for two main reasons: 1. it is a choice between data correctness vs. bugfix version compatibility, and the corresponding query pattern cannot be changed without facing changes if correctness is to be guaranteed 2. Considering that 1.16.0 is the first initial release of a major version, we know that users tend to prefer subsequent bugfix versions for better stability, so the possible incompatibility involved above will be less harmful to users, especially when compared to data correctness Glad to hear your suggestions. Best, Lincoln Lee Sergey Nuyanzin <snuyan...@gmail.com> 于2022年12月18日周日 15:41写道： > Hi Martijn, > > +1 > thanks for bringing this up > > > On Sat, Dec 17, 2022 at 5:11 PM Konstantin Knauf <kna...@apache.org> > wrote: > > > Hi Martijn, > > > > thanks for bringing it up and +1 to do a release rather soon. > > > > Best, > > > > Konstantin > > > > Am Fr., 16. Dez. 2022 um 06:17 Uhr schrieb ConradJam < > jam.gz...@gmail.com > > >: > > > > > Hi Martijn, > > > > > > Thank you for bringing this up. I'm in favor of this proposal, by the > > way, > > > FLINK-30116 has been fixed > > > > > > > > > > > > Martijn Visser <martijnvis...@apache.org> 于2022年12月16日周五 02:52写道： > > > > > > > Hi everyone, > > > > > > > > I would like to open a discussion about releasing Flink 1.16.1. We've > > > > released Flink 1.16 at the end of October, but we already have 58 > fixes > > > > listed for 1.16.1, including a blocker [1] on the environment > variables > > > and > > > > a number of critical issues. Some of the critical issues are related > to > > > the > > > > bugs on the Sink API, on PyFlink and some correctness issues. > > > > > > > > There are also a number of open issues with a fixVersion set to > 1.16.1, > > > so > > > > it would be good to understand what the community thinks of starting > a > > > > release or if there are some fixes that should be included with > 1.16.1. > > > > > > > > Best regards, > > > > > > > > Martijn > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-30116 > > > > > > > > > > > > > -- > > > Best > > > > > > ConradJam > > > > > > > > > -- > > https://twitter.com/snntrable > > https://github.com/knaufk > > > > > -- > Best regards, > Sergey >
