+1 (binding) - Verified source, helm release and signatures - Docs, javadocs look good - Helm chart points to correct image, installed locally from helm repo and run some apps - Maven repo contents look clean and correct - Checked release notes on JIRA
Looks great Matyas, awesome work! Cheers Gyula On Mon, Dec 12, 2022 at 5:04 PM Maximilian Michels <m...@apache.org> wrote: > +1 (binding) > > Source release looks good. > > 1. Downloaded, compiled, and verified the signature of the source release > staged at > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.3.0-rc1/ > < > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.2.0-rc2/ > > > 2. Verified licenses (Not a blocker: the LICENSE file does not contain a > link to the bundled licenses directory, this should be fixed in future > releases) > 3. Verified Helm Chart > 4. Deployed on K8s and ran Flink jobs > > -Max > > On Sat, Dec 10, 2022 at 12:17 PM Péter Váry <peter.vary.apa...@gmail.com> > wrote: > > > +1 (non-binding) > > 1. Checked the artifacts (binaries, headers, versions) > > 2. Checked the signatures > > 3. Compiled code > > 4. Created docker images > > 5. Run some manual tests > > 6. Run the examples > > > > Other than one small issue (which is a local one) everything works like > > charm. > > > > Thanks Matyas for taking care of this. > > > > Peter > > > > Hao t Chang <htch...@us.ibm.com> ezt írta (időpont: 2022. dec. 9., P, > > 0:25): > > > > > Thank Matyas > > > > > > +1(non-binding) > > > 1. Ran bundle generator with the > > > ghcr.io/apache/flink-kubernetes-operator:b7e40da image > > > 2. Deploy to K8s and OpenShift and create basic examples. > > > 3. Ran bundle CI tests suits > > > > > > -- > > > Best, > > > Ted Chang | Software Engineer | htch...@us.ibm.com > > > > > > > > >
