+1 (binding) Verified the following: - verified the checksum and signature of the source and binary distribution - built from source code without exception. (Some unit tests failed because rocksdb doesn't work well with the Apple silicon). - checked the source jar and it does not contain any binary files. - verified the pom files and the flink-ml versions are updated.
Thanks, Jiangjie (Becket) Qin On Tue, Jul 5, 2022 at 3:58 PM Yun Gao <yungao...@aliyun.com.invalid> wrote: > +1 (binding) > > - Verified the checksum and signatures. > - Build from sources without exceptions. > - Checked the artifacts uploading to the mvn repo is completed. > - Reviewed the release PR and LGTM. > > Best, > Yun Gao > > > > > ------------------------------------------------------------------ > From:Dian Fu <dian0511...@gmail.com> > Send Time:2022 Jul. 5 (Tue.) 14:45 > To:dev <dev@flink.apache.org> > Subject:Re: [VOTE] Apache Flink ML Release 2.1.0, release candidate #2 > > +1 (binding) > > - Verified the checksum and signature > - Installed the Python package and runs an example documented here[1] > - Reviewed the website PR and LGTM overall > > Regards, > Dian > > [1] > > https://nightlies.apache.org/flink/flink-ml-docs-master/docs/operators/clustering/kmeans/#examples > > On Mon, Jul 4, 2022 at 2:01 PM Yunfeng Zhou <flink.zhouyunf...@gmail.com> > wrote: > > > Thanks for raising this release candidate. > > > > +1 (non-binding) > > > > - Verified that the checksums and GPG files match the corresponding > release > > files. > > - Verified that the source distributions do not contain any binaries. > > - Built the source distribution and ensured that all source files have > > Apache headers. > > - Verified that all POM files point to the same version. > > - Browsed through JIRA release notes files and did not find anything > > unexpected. > > - Browsed through README.md files and did not find anything unexpected. > > - Checked the source code tag "release-2.0.0-rc2" and did not find > anything > > unexpected. > > > > > > On Fri, Jul 1, 2022 at 11:57 AM Dong Lin <lindon...@gmail.com> wrote: > > > > > Thanks for the update! > > > > > > +1 (non-binding) > > > > > > Here is what I checked. All required checks are included. > > > > > > - Verified that the checksums and GPG files match the corresponding > > release > > > files. > > > - Verified that the source distributions do not contain any binaries. > > > - Built the source distribution and ensured that all source files have > > > Apache headers. > > > - Verified that all POM files point to the same version. > > > - Browsed through JIRA release notes files and did not find anything > > > unexpected. > > > - Browsed through README.md files and did not find anything unexpected. > > > - Checked the source code tag "release-2.0.0-rc2" and did not find > > anything > > > unexpected. > > > > > > > > > On Fri, Jul 1, 2022 at 11:11 AM Zhipeng Zhang <zhangzhipe...@gmail.com > > > > > wrote: > > > > > > > Hi everyone, > > > > > > > > > > > > Please review and vote on the release candidate #2 for the version > > 2.1.0 > > > of > > > > Apache Flink ML as follows: > > > > > > > > [ ] +1, Approve the release > > > > > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > > > > **Testing Guideline** > > > > > > > > > > > > You can find here [1] a page in the project wiki on instructions for > > > > testing. > > > > > > > > To cast a vote, it is not necessary to perform all listed checks, but > > > > please > > > > > > > > mention which checks you have performed when voting. > > > > > > > > > > > > **Release Overview** > > > > > > > > > > > > As an overview, the release consists of the following: > > > > > > > > a) Flink ML source release to be deployed to dist.apache.org > > > > > > > > b) Flink ML Python source distributions to be deployed to PyPI > > > > > > > > c) Maven artifacts to be deployed to the Maven Central Repository > > > > > > > > > > > > **Staging Areas to Review** > > > > > > > > > > > > The staging areas containing the above mentioned artifacts are as > > > follows, > > > > for your review: > > > > > > > > * All artifacts for a) and b) can be found in the corresponding dev > > > > repository at dist.apache.org [2], > > > > > > > > which are signed with the key with fingerprint > > > > 0789F389E67ADDFA034E603FABF0C46E59C8941C [3] > > > > > > > > * All artifacts for c) can be found at the Apache Nexus Repository > [4] > > > > > > > > > > > > Other links for your review: > > > > > > > > * JIRA release notes [5] > > > > > > > > * Source code tag "release-2.0.0-rc2" [6] > > > > > > > > * PR to update the website Downloads page to include Flink ML links > [7] > > > > > > > > > > > > **Vote Duration** > > > > > > > > The voting time will run for at least 72 hours. > > > > > > > > It is adopted by majority approval, with at least 3 PMC affirmative > > > votes. > > > > > > > > > > > > Thanks, > > > > > > > > Yun and Zhipeng > > > > > > > > > > > > [1] > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+ML+Release > > > > > > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-ml-2.1.0-rc2/ > > > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > [4] > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1517/ > > > > > > > > [5] > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351141 > > > > > > > > [6] > https://github.com/apache/flink-ml/releases/tag/release-2.1.0-rc2 > > > > > > > > [7] https://github.com/apache/flink-web/pull/556 > > > > > > > > > > >
