Hi Konstantin, I agree this issue has been around for a while now, but Flink 1.15's savepoint ownership changes make it much more likely to cause issues.
Since it is not a regression of 1.15.0 we can fix it in the next patch release. +0 from me too. Thanks On Mon, 4 Jul 2022, 07:45 Jingsong Li, <jingsongl...@gmail.com> wrote: > Hi Dawid and Konstantin. > > +0 for this RC. > > Let's move on. > > Best, > Jingsong > > On Mon, Jul 4, 2022 at 2:17 PM Konstantin Knauf <kna...@apache.org> wrote: > > > > Thanks Jingsong. I agree that this is a serious bug and we need to take > > compatibility seriously. We shouldn't wait long until we release Flink > > 1.15.2. Still I stand to my point, that we shouldn't abort the current > > release. > > > > --- > > > > +1 (binding) > > > > * checked release blog post > > * verified signatures and checksums > > * all artifacts present > > > > Best, > > > > Konstantin > > > > > > > > > > > > > > Am Mo., 4. Juli 2022 um 03:46 Uhr schrieb Jingsong Li < > > jingsongl...@gmail.com>: > > > > > Hi Konstantin, > > > > > > I have no problem with canceling -1. > > > > > > However, 1.15.1 will also be a version that is not compatible with > 1.14. > > > I've heard too many complaints about connector compatibility, and > > > Flink always introduces incompatible changes to the connector in every > > > release. > > > Flink's new version can let connector developers modify code, but > > > incompatibilities like FLINK-28322 cause connectors to have to split > > > their code, one for 1.15 and one for 1.14, making the connector side > > > difficult to maintain. > > > > > > > Regressions - in this case between 1.15.0 and 1.15.1 - would usually > > > justify aborting the release candidate > > > > > > My understanding is that as long as there are high impact bugs or > > > compatibility issues, they are blockers, not just the regressions > > > brought about in the new fixes for 1.15.1. > > > > > > Best, > > > Jingsong > > > > > > On Sat, Jul 2, 2022 at 2:09 AM Konstantin Knauf <kna...@apache.org> > wrote: > > > > > > > > Hi everyone, > > > > > > > > I would like to raise the question if we should abort this release > > > > candidate at the current stage because of newly found bugs? > > > > > > > > * The minimal voting period had already passed and with one addition > > > > binding vote (e.g. mine), we could release this immediately and ship > all > > > > the other fixes to users. > > > > > > > > * The way I see the process at this stage of the release, we have > already > > > > decided that we want to release now (otherwise we wouldn't have > prepared > > > a > > > > candidate) and this is only about sanity checking and validating the > > > > release candidate. Regressions - in this case between 1.15.0 and > 1.15.1 - > > > > would usually justify aborting the release candidate, but as far as > I can > > > > see neither FLINK-23528 and FLINK-28322 are regressions. > > > > > > > > @Danny: I don't understand how FINK-23528 is a blocker for this > release > > > > candidate, sorry. It's been open for almost a year. Of course, it > should > > > > then go into the next patch release of Flink 1.15. > > > > > > > > @Jingsong: Please re-consider your -1 vote. > > > > > > > > Thanks, > > > > > > > > Konstantin > > > > > > > > > > > > Am Do., 30. Juni 2022 um 18:21 Uhr schrieb Danny Cranmer < > > > > dannycran...@apache.org>: > > > > > > > > > Hello all, > > > > > > > > > > -1 > > > > > > > > > > The Kinesis Data Streams consumer does not work with Stop With > > > Savepoint > > > > > [1]. We are planning to have a fix ready to merge tomorrow and > would > > > > > appreciate getting this in 1.15.1. > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-23528 > > > > > > > > > > Thanks, > > > > > Danny > > > > > > > > > > On Thu, Jun 30, 2022 at 9:31 AM Jingsong Li < > jingsongl...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hi David, Thanks for creating this RC. > > > > > > > > > > > > -1 > > > > > > > > > > > > We found an incompatible modification in 1.15.0 [1] > > > > > > I think we should fix it. > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-28322 > > > > > > > > > > > > Best, > > > > > > Jingsong > > > > > > > > > > > > On Tue, Jun 28, 2022 at 8:45 PM Robert Metzger < > metrob...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > - staging repo contents look fine > > > > > > > - KEYS file ok > > > > > > > - binaries start locally properly. WebUI accessible on Mac. > > > > > > > > > > > > > > On Mon, Jun 27, 2022 at 11:21 AM Qingsheng Ren < > re...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > - checked/verified signatures and hashes > > > > > > > > - checked that all POM files point to the same version > > > > > > > > - built from source, without Hadoop and using Scala 2.12 > > > > > > > > - started standalone cluster locally, WebUI is accessiable > and > > > ran > > > > > > > > WordCount example successfully > > > > > > > > - executed a job with SQL client consuming from Kafka source > to > > > > > collect > > > > > > > > sink > > > > > > > > > > > > > > > > Best, > > > > > > > > Qingsheng > > > > > > > > > > > > > > > > > > > > > > > > > On Jun 27, 2022, at 14:46, Xingbo Huang < > hxbks...@gmail.com> > > > > > wrote: > > > > > > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > > > > > - verify signatures and checksums > > > > > > > > > - no binaries found in source archive > > > > > > > > > - build from source > > > > > > > > > - Reviewed the release note blog > > > > > > > > > - verify python wheel package contents > > > > > > > > > - pip install apache-flink-libraries and apache-flink wheel > > > > > packages > > > > > > > > > - run the examples from Python Table API tutorial > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > Xingbo > > > > > > > > > > > > > > > > > > Chesnay Schepler <ches...@apache.org> 于2022年6月24日周五 > 21:42写道： > > > > > > > > > > > > > > > > > >> +1 (binding) > > > > > > > > >> > > > > > > > > >> - signatures OK > > > > > > > > >> - all required artifacts appear to be present > > > > > > > > >> - tag exists with the correct version adjustments > > > > > > > > >> - binary shows correct commit and version > > > > > > > > >> - examples run fine > > > > > > > > >> - website PR looks good > > > > > > > > >> > > > > > > > > >> On 22/06/2022 14:20, David Anderson wrote: > > > > > > > > >>> Hi everyone, > > > > > > > > >>> > > > > > > > > >>> Please review and vote on release candidate #1 for > version > > > > > 1.15.1, > > > > > > as > > > > > > > > >>> follows: > > > > > > > > >>> [ ] +1, Approve the release > > > > > > > > >>> [ ] -1, Do not approve the release (please provide > specific > > > > > > comments) > > > > > > > > >>> > > > > > > > > >>> The complete staging area is available for your review, > which > > > > > > includes: > > > > > > > > >>> > > > > > > > > >>> * JIRA release notes [1], > > > > > > > > >>> * the official Apache source release and binary > convenience > > > > > > releases to > > > > > > > > >> be > > > > > > > > >>> deployed to dist.apache.org [2], which are signed with > the > > > key > > > > > > with > > > > > > > > >>> fingerprint E982F098 [3], > > > > > > > > >>> * all artifacts to be deployed to the Maven Central > > > Repository > > > > > [4], > > > > > > > > >>> * source code tag "release-1.15.1-rc1" [5], > > > > > > > > >>> * website pull request listing the new release and adding > > > > > > announcement > > > > > > > > >> blog > > > > > > > > >>> post [6]. > > > > > > > > >>> > > > > > > > > >>> The vote will be open for at least 72 hours. It is > adopted by > > > > > > majority > > > > > > > > >>> approval, with at least 3 PMC affirmative votes. > > > > > > > > >>> > > > > > > > > >>> Thanks, > > > > > > > > >>> David > > > > > > > > >>> > > > > > > > > >>> [1] > > > > > > > > >>> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version= > > > > > > > > >>> 12351546 > > > > > > > > >>> [2] > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.15.1-rc1/ > > > > > > > > >>> [3] > https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > >>> [4] > > > > > > > > >> > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1511/ > > > > > > > > >>> [5] > https://github.com/apache/flink/tree/release-1.15.1-rc1 > > > > > > > > >>> [6] https://github.com/apache/flink-web/pull/554 > > > > > > > > >>> > > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > https://twitter.com/snntrable > > > > https://github.com/knaufk > > > > > > > > > -- > > https://twitter.com/snntrable > > https://github.com/knaufk >
