Thanks Marton, I vote for consistency and `flink-kubernetes-operator` as well. `flink-operator` have been used widely in docker hub and other k8s operator implementations, which may confuse users.
Best, Biao Gyula Fóra <gyf...@apache.org> 于2022年3月30日周三 16:26写道： > Thanks Marton! > I think we should aim for consistency and easy discoverability. Since we > use the name `flink-kubernetes-operator` for the project and everywhere on > the website to refer to it, I suggest adopting it as the name also. > > This should be a very simple change that we can easily do before the next > rc if there are no objections. > > Gyula > > On Wed, Mar 30, 2022 at 10:10 AM Márton Balassi <balassi.mar...@gmail.com> > wrote: > > > Hi team, > > > > I would like to ask for your input in naming the operator docker image > and > > helm chart. [1] > > > > For the sake of brevity when we started the Kubernetes Operator work we > > named the docker image and the helm chart simply flink-operator, while > the > > git repository is named flink-kubernetes-operator. [2] > > Now closing in on our preview release it makes sense to reconsider this, > it > > might be preferred to name all artifacts flink-kubernetes-operator for > the > > sake of consistency. > > Currently docker images of our builds are available in the GitHub > Registry > > tagged with the short git commit hash and the last build of select > branches > > is tagged with the branch name: > > > > ghcr.io/apache/flink-operator:439bd41ghcr.io/apache/flink-operator:main > > > > During the release process we plan to move the docker image to dockerhub > > following the process established for Flink. > > Currently the helm operator for the release candidate can be installed as > > follows: > > > > helm repo add operator-rc2 > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-0.1.0-rc2 > > helm install flink-operator operator-rc2/flink-operator > > > > So the helm chart itself is called flink-operator, but to follow the name > > of the project it is packaged into > flink-kubernetes-operator-<version>.tgz. > > Do you prefer flink-operator for brevity or flink-kubernetes-operator for > > consistency? If we vote for changing the current setup we could get the > > changes in for the next RC. > > > > [1] https://issues.apache.org/jira/browse/FLINK-26924 > > [2] https://github.com/apache/flink-kubernetes-operator > > [3] > > > > > https://cwiki.apache.org/confluence/display/FLINK/Creating+a+Flink+Release#CreatingaFlinkRelease-PublishtheDockerfilesforthenewrelease > > > > On Wed, Mar 30, 2022 at 9:17 AM Gyula Fóra <gyula.f...@gmail.com> wrote: > > > > > Hi Devs, > > > > > > I am cancelling the current vote as we have promoted > > > https://issues.apache.org/jira/browse/FLINK-26916 as a blocker issue. > > > > > > Yang has found a fix that we can reasonably do in a short time frame, > so > > we > > > will work on that today before creating the next RC (hopefully later > > today) > > > > > > Thank you! > > > Gyula > > > > > > On Tue, Mar 29, 2022 at 7:51 PM Gyula Fóra <gyula.f...@gmail.com> > wrote: > > > > > > > Hi Devs, > > > > > > > > I just want to give you heads up regarding a significant issue Matyas > > > > found around the last-state upgrade mode: > > > > https://issues.apache.org/jira/browse/FLINK-26916 > > > > > > > > Long story short, the last-state mode does not actually upgrade the > > job, > > > > only the job/taskmanagers. The fix is non-trivial to say the least > and > > > > requires changes to the Flink Kubernetes HA implementations to be > > > feasible. > > > > Please see the jira ticket for details. > > > > > > > > I discussed this offline with Thomas Weise and we agreed to clearly > > > > highlight this limitation with warnings in the documentation and the > > > > release blogpost but not block the release on it as the fix will most > > > > likely require Flink 1.15 if we can include the required changes > there. > > > > > > > > Please continue testing the current RC :) > > > > > > > > Thank you all! > > > > Gyula > > > > > > > > > > > > On Tue, Mar 29, 2022 at 5:17 PM Chenya Zhang <che...@apache.org> > > wrote: > > > > > > > >> +1 non-binding, thanks for the great efforts and look forward to the > > > >> release! > > > >> > > > >> Chenya > > > >> > > > >> On Tue, Mar 29, 2022 at 2:10 AM Gyula Fóra <gyf...@apache.org> > wrote: > > > >> > > > >> > Hi everyone, > > > >> > > > > >> > Please review and vote on the release candidate #2 for the version > > > >> 0.1.0 of > > > >> > Apache Flink Kubernetes Operator, > > > >> > as follows: > > > >> > [ ] +1, Approve the release > > > >> > [ ] -1, Do not approve the release (please provide specific > > comments) > > > >> > > > > >> > **Release Overview** > > > >> > > > > >> > As an overview, the release consists of the following: > > > >> > a) Kubernetes Operator canonical source distribution (including > the > > > >> > Dockerfile), to be deployed to the release repository at > > > >> dist.apache.org > > > >> > b) Kubernetes Operator Helm Chart to be deployed to the release > > > >> repository > > > >> > at dist.apache.org > > > >> > c) Maven artifacts to be deployed to the Maven Central Repository > > > >> > d) Docker image to be pushed to dockerhub > > > >> > > > > >> > **Staging Areas to Review** > > > >> > > > > >> > The staging areas containing the above mentioned artifacts are as > > > >> follows, > > > >> > for your review: > > > >> > * All artifacts for a,b) can be found in the corresponding dev > > > >> repository > > > >> > at dist.apache.org [1] > > > >> > * All artifacts for c) can be found at the Apache Nexus Repository > > [2] > > > >> > * The docker image is staged on github [7] > > > >> > > > > >> > All artifacts are signed with the > > > >> > key 911F218F79ACEA8EB453799EEE325DDEBFED467D [3] > > > >> > > > > >> > Other links for your review: > > > >> > * JIRA release notes [4] > > > >> > * source code tag "release-0.1.0-rc2" [5] > > > >> > * PR to update the website Downloads page to include Kubernetes > > > Operator > > > >> > links [6] > > > >> > > > > >> > **Vote Duration** > > > >> > > > > >> > The voting time will run for at least 72 hours. > > > >> > It is adopted by majority approval, with at least 3 PMC > affirmative > > > >> votes. > > > >> > > > > >> > **Note for Functional Verification** > > > >> > > > > >> > You can use the dev repository as a helm repo to test the operator > > > >> > directly: > > > >> > > > > >> > helm repo add operator-rc2 > > > >> > > > > >> > > > > >> > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-0.1.0-rc2 > > > >> > helm install flink-operator operator-rc2/flink-operator > > > >> > > > > >> > Thanks, > > > >> > Gyula > > > >> > > > > >> > [1] > > > >> > > > > >> > > > > >> > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-0.1.0-rc2/ > > > >> > [2] > > > >> > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1491/ > > > >> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >> > [4] > > > >> > > > > >> > > > > >> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351499 > > > >> > [5] > > > >> > > > > >> > > > > > > https://github.com/apache/flink-kubernetes-operator/tree/release-0.1.0-rc2 > > > >> > [6] https://github.com/apache/flink-web/pull/519 > > > >> > [7] ghcr.io/apache/flink-operator:260df17 > > > >> > > > > >> > > > > > > > > > >
