Thanks Matyas, >From a user perspective I think the annotation is pretty nice and user friendly so I personally prefer that approach.
You said: "It seems, the java-operator-sdk handles the changes of the .metadata and .spec fields of custom resources differently." What implications does this have on the above mentioned 2 approaches? Does it make one more difficult than the other? Cheers Gyula On Tue, Mar 1, 2022 at 1:52 PM Őrhidi Mátyás <matyas.orh...@gmail.com> wrote: > Hi All! > > I'd like to start a quick discussion about the way we allow users to > trigger savepoints manually in the operator [FLINK-26181] > <https://issues.apache.org/jira/browse/FLINK-26181>. There are existing > solutions already for this functionality in other operators, for example: > - counter based > < > https://github.com/spotify/flink-on-k8s-operator/blob/master/docs/savepoints_guide.md#2-taking-savepoints-by-updating-the-flinkcluster-custom-resource > > > - annotation based > < > https://github.com/spotify/flink-on-k8s-operator/blob/master/docs/savepoints_guide.md#3-taking-savepoints-by-attaching-annotation-to-the-flinkcluster-custom-resource > > > > We could implement any of these or both or come up with our own approach. > It seems, the java-operator-sdk handles the changes of the .metadata and > .spec fields of custom resources differently. For further info see the > chapter Generation Awareness and Event Filtering in the docs > <https://javaoperatorsdk.io/docs/features>. > > Let me know what you think. > > Cheers, > Matyas >
