Hi all, I'd like to ask if it is fine to merge this PR[1]. It is an extension of sink metrics that has been covered originally by FLIP-33 [2]. Such extension has been pointed out there: "*The following metric convention is not a complete list. More conventional metrics will be added over time.*" The change itself is trivial. Please let me know if there is any concern. Thanks.
Best regards, Jing [1] https://github.com/apache/flink/pull/18825 [2] https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics On Wed, Feb 23, 2022 at 11:59 AM Till Rohrmann <trohrm...@apache.org> wrote: > Hi Fabian, > > Thanks for letting us know. I believe that it should be ok to merge this PR > since it is only affecting the ES connector. > > Cheers, > Till > > On Wed, Feb 23, 2022 at 10:54 AM Fabian Paul <fp...@apache.org> wrote: > > > Hi all, > > > > I would like to merge the following PR [1]. It has been approved > > before the feature freeze but no one had time to merge it, > > unfortunately. The feature is very contained and only adds a simple > > capability to the Elastic connector when used with Flink SQL. If there > > are no concerns until end of day I am going to merge it. > > > > Best, > > Fabian > > > > [1] https://github.com/apache/flink/pull/18058 > > > > On Fri, Feb 18, 2022 at 12:37 PM Till Rohrmann <trohrm...@apache.org> > > wrote: > > > > > > Thanks for letting us know Wenlong. Since the SQL client testing hasn't > > > really started yet, I think it is ok to merge this PR. > > > > > > Cheers, > > > Till > > > > > > On Thu, Feb 17, 2022 at 2:32 PM wenlong.lwl <wenlong88....@gmail.com> > > wrote: > > > > > > > Hi,all, I want to merge a pr ( > > https://github.com/apache/flink/pull/18363) > > > > belonging to FLIP-190, which was approved yesterday, but not merged > > before > > > > code freeze because of CI queueing and failed by other changes. > > > > WDYT? > > > > > > > > Best, > > > > Wenlong > > > > > > > > On Thu, 17 Feb 2022 at 02:08, Till Rohrmann <trohrm...@apache.org> > > wrote: > > > > > > > > > Hi everyone, > > > > > > > > > > The deadline for merging new features for Flink 1.15 has passed. > > > > > > > > > > * From now on, only bug-fixes and documentation fixes / > improvements > > are > > > > > allowed to be merged into the master branch. > > > > > > > > > > * New features merged after this point can be reverted. If you need > > an > > > > > exception to this rule, please open a discussion on dev@ list and > > reach > > > > > out > > > > > to us. > > > > > > > > > > We plan to wait for the master branch to get a bit more stabilized > > before > > > > > cutting the "release-1.15" branch, in order to reduce the overhead > of > > > > > having to manage two branches. That also means potentially delaying > > > > merging > > > > > new features for Flink 1.16 into the master branch. If you are > > blocked on > > > > > this, please let us know and we can come up with a compromise for > the > > > > > branch cutting time. > > > > > > > > > > What you can do to help with the release testing phase: > > > > > > > > > > * The first release testing sync will be on *February 22, 9am CET*. > > > > > Everyone is welcome to join. The link can be found on the release > > wiki > > > > page > > > > > [1]. > > > > > > > > > > * Please prepare for the release testing by creating Jira tickets > for > > > > > documentation and testing tasks for the new features. Tickets > should > > be > > > > > opened with Priority Blocker, FixVersion 1.15.0 and Label > > release-testing > > > > > (testing tasks only). > > > > > > > > > > * There are currently 92 test-stability issues affecting the 1.15.0 > > > > release > > > > > [2]. It is greatly appreciated if you can help address some of > them. > > > > > > > > > > Cheers, > > > > > Joe, Yun & Till > > > > > > > > > > [1] https://cwiki.apache.org/confluence/display/FLINK/1.15+Release > > > > > [2] https://issues.apache.org/jira/issues/?filter=12351363 > > > > > > > > > > > >
