> Shameless plug:  Maybe the Wikipedia EventStreams
<https://wikitech.wikimedia.org/wiki/Event_Platform/EventStreams> SSE API
<https://stream.wikimedia.org/?doc#/streams> would make for a great
connector example in Flink?

Sounds like a great idea! Do you have a ready to use Java Client for that?

On Mon, Jan 31, 2022 at 3:47 PM Jing Ge <j...@ververica.com> wrote:

> Thanks @Martijn for driving this! +1 for deprecating and removing it. All
> the concerns mentioned previously are valid. It is good to know that the
> upcoming connector template/archetype will help the user for the kickoff.
> Beyond that, speaking of using a real connector as a sample, since Flink is
> heading towards the unified batch and stream processing, IMHO, it would be
> nice to pick up a feasible connector for this trend to let the user get a
> sample close to the use cases.
>
> Best regards
> Jing
>
> On Mon, Jan 31, 2022 at 3:07 PM Andrew Otto <o...@wikimedia.org> wrote:
>
>> Shameless plug:  Maybe the Wikipedia EventStreams
>> <https://wikitech.wikimedia.org/wiki/Event_Platform/EventStreams> SSE API
>> <https://stream.wikimedia.org/?doc#/streams> would make for a great
>> connector example in Flink?
>>
>> :D
>>
>> On Mon, Jan 31, 2022 at 5:41 AM Martijn Visser <mart...@ververica.com>
>> wrote:
>>
>>> Hi all,
>>>
>>> Thanks for your feedback. It's not about having this connector in the
>>> main repo, that has been voted on already. This is strictly about the
>>> connector itself, since it's not maintained and most probably also can't be
>>> used due to changes in Twitter's API that aren't reflected in our connector
>>> implementation. Therefore I propose to remove it.
>>>
>>> Fully agree on the template part, what's good to know is that a
>>> connector template/archetype is part of the goals for the external
>>> connector repository.
>>>
>>> Best regards,
>>>
>>> Martijn
>>>
>>> On Mon, 31 Jan 2022 at 11:32, Francesco Guardiani <
>>> france...@ververica.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I agree with the concern about having this connector in the main repo.
>>>> But I think in general it doesn't harm to have a sample connector to show
>>>> how to develop a custom connector, and I think that the Twitter connector
>>>> can be a good candidate for such a template. It needs rework for sure, as
>>>> it has evident issues, notably it doesn't work with table.
>>>>
>>>> So i understand if we wanna remove what we have right now, but I think
>>>> we should have some replacement for a "connector template", which is both
>>>> ready to use and easy to hack to build your own connector starting from it.
>>>> Twitter API is a good example for such a template, as it's both "related"
>>>> to the known common use cases of Flink and because is quite simple to get
>>>> started with.
>>>>
>>>> FG
>>>>
>>>> On Sun, Jan 30, 2022 at 12:31 PM David Anderson <da...@alpinegizmo.com>
>>>> wrote:
>>>>
>>>>> I agree.
>>>>>
>>>>> The Twitter connector is used in a few (unofficial) tutorials, so if
>>>>> we remove it that will make it more difficult for those tutorials to be
>>>>> maintained. On the other hand, if I recall correctly, that connector uses
>>>>> V1 of the Twitter API, which has been deprecated, so it's really not very
>>>>> useful even for that purpose.
>>>>>
>>>>> David
>>>>>
>>>>>
>>>>>
>>>>> On Fri, Jan 21, 2022 at 9:34 AM Martijn Visser <mart...@ververica.com>
>>>>> wrote:
>>>>>
>>>>>> Hi everyone,
>>>>>>
>>>>>> I would like to discuss deprecating Flinks' Twitter connector [1].
>>>>>> This was one of the first connectors that was added to Flink, which could
>>>>>> be used to access the tweets from Twitter. Given the evolution of Flink
>>>>>> over Twitter, I don't think that:
>>>>>>
>>>>>> * Users are still using this connector at all
>>>>>> * That the code for this connector should be in the main Flink
>>>>>> codebase.
>>>>>>
>>>>>> Given the circumstances, I would propose to deprecate and remove this
>>>>>> connector. I'm looking forward to your thoughts. If you agree, please 
>>>>>> also
>>>>>> let me know if you think we should first deprecate it in Flink 1.15 and
>>>>>> remove it in a version after that, or if you think we can remove it
>>>>>> directly.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> Martijn Visser
>>>>>> https://twitter.com/MartijnVisser82
>>>>>>
>>>>>> [1]
>>>>>> https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/twitter/
>>>>>>
>>>>>>

Reply via email to