+1 (binding) - Verified the checksum and signature - Build the Java code and also run the tests using `mvn clean verify` - Checked the NOTICE file - Pip installed the python package in MacOS under Python 3.7 - Reviewed the flink-web PR
Regards, Dian On Tue, Jan 4, 2022 at 12:25 AM Dong Lin <lindon...@gmail.com> wrote: > Thank you Till for the vote. > > FYI, if you were not able to use `pip3 install` to verify the python source > release, that might be because you are using Python 3.9 (or later versions) > with pip3. The issue could be fixed by using e.g. Python 3.8. > > The supported python versions are documented in flink-ml-python/README.md > but we forgot to enforce this check in the setup.py previously. We have > merged PR (link <https://github.com/apache/flink-ml/pull/51>) to improve > the error message in the master branch. > > > > > On Mon, Jan 3, 2022 at 10:10 PM Till Rohrmann <trohrm...@apache.org> > wrote: > > > +1 (binding) > > > > - Checked the checksums and signatures > > - Built java part from source release > > - Ran all Java tests > > - Checked the blog post PR > > > > What I did not manage to do is to build the Python part locally. I assume > > that this was due to my local Python setup. Maybe somebody else can > double > > check this part if not already done. > > > > Cheers, > > Till > > > > On Fri, Dec 31, 2021 at 10:16 AM Xingbo Huang <hxbks...@gmail.com> > wrote: > > > > > +1 （non-binding) > > > > > > - Verified checksums and signatures > > > - Pip install the apache-flink-ml package > > > - Run the apache-flink-ml tests (We will add more python examples in > the > > > next release https://issues.apache.org/jira/browse/FLINK-25497). > > > > > > Best, > > > Xingbo > > > > > > Zhipeng Zhang <zhangzhipe...@gmail.com> 于2021年12月31日周五 15:01写道： > > > > > > > +1 (non-binding) > > > > > > > > - Verified that the checksums and GPG files match the corresponding > > > release > > > > files > > > > - Verified that the source distributions do not contain any binaries > > > > - Built the source distribution with Maven to ensure all source files > > > have > > > > Apache headers > > > > - Verified that all POM files point to the same version > > > > - Verified that the README.md file does not have anything unexpected > > > > - Verified the NOTICE and LICENSE follows the rules > > > > - Checked JIRA release notes > > > > - Checked source code tag "release-2.0.0-rc3" > > > > > > > > > > > > Dong Lin <lindon...@gmail.com> 于2021年12月31日周五 09:09写道： > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified that the checksums and GPG files match the corresponding > > > > release > > > > > files > > > > > - Verified that the source distributions do not contain any > binaries > > > > > - Built the source distribution with Maven to ensure all source > files > > > > have > > > > > Apache headers > > > > > - Verified that all POM files point to the same version > > > > > - Verified that the README.md file does not have anything > unexpected > > > > > - Verified the NOTICE and LICENSE follows the rules specified in > the > > > wiki > > > > > < > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+ML+Release > > > > > > > > > > > . > > > > > - Checked JIRA release notes > > > > > - Checked source code tag "release-2.0.0-rc2" > > > > > - Checked flink-web PR > > > > > > > > > > > > > > > > > > > > On Fri, Dec 31, 2021 at 1:24 AM Yun Gao <yungao...@aliyun.com> > > wrote: > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > > > > > > > Please review and vote on the release candidate #3 for the > version > > > > 2.0.0 > > > > > > of Apache Flink ML, > > > > > > > > > > > > as follows: > > > > > > > > > > > > [ ] +1, Approve the release > > > > > > > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > > > > > > > > > > > > > **Testing Guideline** > > > > > > > > > > > > > > > > > > > > > > > > You can find here [1] a page in the project wiki on instructions > > for > > > > > > testing. To cast a vote, it is not necessary to perform all > listed > > > > > checks, > > > > > > but please mention which checks you have performed when voting. > > > > > > > > > > > > > > > > > > > > > > > > **Release Overview** > > > > > > > > > > > > > > > > > > > > > > > > As an overview, the release consists of the following: > > > > > > > > > > > > a) Flink ML source release to be deployed to dist.apache.org > > > > > > > > > > > > b) Flink ML Python source distributions to be deployed to PyPI > > > > > > > > > > > > c) Maven artifacts to be deployed to the Maven Central Repository > > > > > > > > > > > > > > > > > > > > > > > > **Staging Areas to Review** > > > > > > > > > > > > > > > > > > > > > > > > The staging areas containing the above mentioned artifacts are as > > > > > follows, > > > > > > for your review: > > > > > > > > > > > > * All artifacts for a) and b) can be found in the corresponding > dev > > > > > > repository at dist.apache.org [2], which are signed with the key > > > with > > > > > > fingerprint CBE82BEFD827B08AFA843977EDBF922A7BC84897 [3] > > > > > > > > > > > > * All artifacts for c) can be found at the Apache Nexus > Repository > > > [4] > > > > > > > > > > > > > > > > > > > > > > > > Other links for your review: > > > > > > > > > > > > * JIRA release notes [5] > > > > > > > > > > > > * Source code tag "release-2.0.0-rc3" [6] > > > > > > > > > > > > * PR to update the website Downloads page to include Flink ML > links > > > [7] > > > > > > > > > > > > > > > > > > > > > > > > **Vote Duration** > > > > > > > > > > > > > > > > > > > > > > > > The voting time will run for at least 72 hours. > > > > > > > > > > > > It is adopted by majority approval, with at least 3 PMC > affirmative > > > > > votes. > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Dong and Yun > > > > > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+ML+Release > > > > > > > > > > > > [2] > > https://dist.apache.org/repos/dist/dev/flink/flink-ml-2.0.0-rc3 > > > > > > > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > > > > > [4] > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1477 > > > > > > > > > > > > [5] > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351079 > > > > > > > > > > > > [6] > > > https://github.com/apache/flink-ml/releases/tag/release-2.0.0-rc3 > > > > > > > > > > > > [7] https://github.com/apache/flink-web/pull/493 > > > > > > > > > > > > > > > > > > > > > > > -- > > > > best, > > > > Zhipeng > > > > > > > > > >
