@David Morávek <d...@apache.org> great idea! I've opened a subtask to add that check after we fix the existing deprecations.
Seth On Mon, Nov 8, 2021 at 12:55 PM David Morávek <d...@apache.org> wrote: > Hi Seth, thanks for bringing this up. What do you think about placing a > safeguard for this? We should be able to setup java compiler for examples > to fail on any usage of deprecated APIs. > > Something along the lines of: > > <plugin> > <artifactId>maven-compiler-plugin</artifactId> > <version>...</version> > <executions> > <execution> > <id>compile</id> > <phase>process-sources</phase> > <goals> > <goal>compile</goal> > </goals> > <configuration> > <compilerArgument>-Xlint:deprecation</compilerArgument> > <failOnWarning>true</failOnWarning> > </configuration> > </execution> > </executions> > </plugin> > > Best, > D. > > On Mon, Nov 8, 2021 at 4:59 PM Till Rohrmann <trohrm...@apache.org> wrote: > > > Thanks for raising awareness for keeping our examples up to date. I think > > this is a very good practice and it also helps our users better > understand > > how to use Flink. > > > > Cheers, > > Till > > > > On Mon, Nov 8, 2021 at 4:57 PM Fabian Paul <fabianp...@ververica.com> > > wrote: > > > > > Hi Seth, > > > > > > Thanks for brining up this topic. > > > > > > Huge appreciations that you take this over initially and we should > > > definitely > > > take care as a community to what we show beginner users. > > > > > > We can also take the examples as show cases about things we have > > developed > > > and > > > are proud of. > > > > > > Best, > > > Fabian > > >
