Awesome demo, looking forward to these features! I only have a minor comment: could we provide a config to enable/disable the prompt values? We can also discuss whether we can enable all the new features by default to give them more exposure.
Best, Jark On Tue, 2 Nov 2021 at 10:48, JING ZHANG <beyond1...@gmail.com> wrote: > Amazing improvements and impressive video. > Big +1. > > Best, > JING ZHANG > > Kurt Young <ykt...@gmail.com> 于2021年11月2日周二 上午9:37写道： > > > Really cool improvements @Sergey. Can't wait to see it happen. > > > > Best, > > Kurt > > > > > > On Tue, Nov 2, 2021 at 1:56 AM Martijn Visser <mart...@ververica.com> > > wrote: > > > > > Hi Sergey, > > > > > > I guess you've just set a new standard ;-) I agree with Ingo, these > > > improvements look really good! > > > > > > Best regards, > > > > > > Martijn > > > > > > On Mon, 1 Nov 2021 at 18:23, Ingo Bürk <i...@ververica.com> wrote: > > > > > > > Hi Sergey, > > > > > > > > I think those improvements look absolutely amazing. Thanks for the > > little > > > > video! > > > > > > > > > > > > Best > > > > Ingo > > > > > > > > On Mon, Nov 1, 2021, 17:15 Sergey Nuyanzin <snuyan...@gmail.com> > > wrote: > > > > > > > > > Thanks for the feedback Till. > > > > > > > > > > Martijn, I have created a short demo showing some of the features > > > > mentioned > > > > > in FLIP. > > > > > It is available at https://asciinema.org/a/446247?speed=3.0 > > > > > Could you please tell if it is what you are expecting or not? > > > > > > > > > > On Fri, Oct 29, 2021 at 4:59 PM Till Rohrmann < > trohrm...@apache.org> > > > > > wrote: > > > > > > > > > > > Thanks for creating this FLIP Sergey. I think what you propose > > sounds > > > > > like > > > > > > very good improvements for the SQL client. This should make the > > > client > > > > a > > > > > > lot more ergonomic :-) > > > > > > > > > > > > Cheers, > > > > > > Till > > > > > > > > > > > > On Fri, Oct 29, 2021 at 11:26 AM Sergey Nuyanzin < > > > snuyan...@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > Hi Martijn, > > > > > > > > > > > > > > Thank you for your suggestion with POC. > > > > > > > Yes I will do that and come back to this thread probably after > > the > > > > > > weekend > > > > > > > > > > > > > > On Thu, Oct 28, 2021 at 4:38 PM Martijn Visser < > > > > mart...@ververica.com> > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Sergey, > > > > > > > > > > > > > > > > Thanks for taking the initiative to create a FLIP and propose > > > > > > > improvements > > > > > > > > on the SQL client. All usability improvements on the SQL > client > > > are > > > > > > > highly > > > > > > > > appreciated, especially for new users of Flink. Multi-line > > > support > > > > is > > > > > > > > definitely one of those things I've run into myself. > > > > > > > > > > > > > > > > I do think it would be quite nice if there would be some kind > > of > > > > POC > > > > > > > which > > > > > > > > could show (some of) the proposed improvements. Is that > > something > > > > > that > > > > > > > > might be easily feasible? > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > > Martijn > > > > > > > > > > > > > > > > On Thu, 28 Oct 2021 at 11:02, Sergey Nuyanzin < > > > snuyan...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > I want to start a discussion about FLIP-189: SQL Client > > > Usability > > > > > > > > > Improvements. > > > > > > > > > > > > > > > > > > The main changes in this FLIP: > > > > > > > > > > > > > > > > > > - Flink sql client parser improvements so > > > > > > > > > that sql client does not ask for ; inside a quoted > string > > > or a > > > > > > > comment > > > > > > > > > - use prompt to show what sql client is waiting for > > > > > > > > > - introduce syntax highlighting > > > > > > > > > - improve completion > > > > > > > > > > > > > > > > > > For more detailed changes, please refer to FLIP-189[1]. > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-189%3A+SQL+Client+Usability+Improvements > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Look forward to your feedback. > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Best regards, > > > > > > > > > Sergey > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Best regards, > > > > > > > Sergey > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Best regards, > > > > > Sergey > > > > > > > > > > > > > > >
