Thank you all for testing this RC and casting your votes! The vote has
passed successfully.

Total 5 +1 votes, and 3 of them are binding:

- Igal Shilman
- Seth Wiesman
- Gordon (Tzu-Li Tai)
- Arvid Heise
- Stephan Ewen

I will announce the release in a separate thread, once all the artifacts
are available.

Thanks,
Igal

On Thu, Aug 26, 2021 at 2:28 PM Stephan Ewen <se...@apache.org> wrote:

> +1 (binding)
>
>   - Build project on Java 8 (maven command line) with full end to end tests
>   - Compiled and ran tests in IDE (IntelliJ) with Java 11 (possible after
> some manual config, see comment below to automate this)
>   - No binaries in the distribution
>   - Verified license and notice files
>   - Checked README
>
>
> Minor issues found, none of which are release blockers:
>
>   - Some warnings in the command line due to a missing version of a plugin.
> Fixing that is good for stability (and better resilience against supply
> chain attacks): See this PR for a fix:
> https://github.com/apache/flink-statefun/pull/261
>
>   - Building in IDE (IntelliJ) with Java 11 does not work out of the box,
> due to issues with the Java Module System and the use of Unsafe in
> generated ProtoBuf classes. See this PR for a fix:
> https://github.com/apache/flink-statefun/pull/262
>
>
>
> On Thu, Aug 26, 2021 at 8:32 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org>
> wrote:
>
> > +1 (binding)
> >
> > - Built from source with Java 11 and Java 8 (mvn clean install
> > -Prun-e2e-tests)
> > - verified signatures and hashes
> > - verified NOTICE files of Maven artifacts properly list actual bundled
> > dependencies
> > - Ran GoLang greeter and showcase with the proposed Dockerfiles for 3.1.0
> > - Ran a local smoke E2E against the Java SDK, with adjusted parameters to
> > run for a longer period of time
> >
> > Thanks for driving the release Igal!
> >
> > Cheers,
> > Gordon
> >
> > On Thu, Aug 26, 2021 at 4:06 AM Seth Wiesman <sjwies...@gmail.com>
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > - verified signatures and hashes
> > > - Checked licenses
> > > - ran mvn clean install -Prun-e2e-tests
> > > - ran golang greeter and showcase from the playground [1]
> > >
> > > Seth
> > >
> > > [1] https://github.com/apache/flink-statefun-playground/pull/12
> > >
> > > On Wed, Aug 25, 2021 at 9:44 AM Igal Shilman <i...@apache.org> wrote:
> > >
> > > > +1 from my side:
> > > >
> > > > Here are the results of my RC2 testing:
> > > >
> > > > - verified the signatures and hashes
> > > > - verified that the source distribution doesn't contain any binary
> > files
> > > > - ran mvn clean install -Prun-e2e-tests
> > > > - ran Java and Python greeters from the playground [1] with the new
> > > module
> > > > structure, and async transport enabled.
> > > > - verified that the docker image [2] builds and inspected the
> contents
> > > > manually.
> > > >
> > > > Thanks,
> > > > Igal
> > > >
> > > > [1] https://github.com/apache/flink-statefun-playground/tree/dev
> > > > [2] https://github.com/apache/flink-statefun-docker/pull/15
> > > >
> > > >
> > > > On Tue, Aug 24, 2021 at 3:34 PM Igal Shilman <i...@apache.org>
> wrote:
> > > >
> > > > > Sorry, the subject of the previous message should have said "[VOTE]
> > > > Apache
> > > > > Flink Stateful Functions 3.1.0, release candidate #2".
> > > > >
> > > > >
> > > > > On Tue, Aug 24, 2021 at 3:24 PM Igal Shilman <i...@apache.org>
> > wrote:
> > > > >
> > > > >> Hi everyone,
> > > > >>
> > > > >> Please review and vote on the release candidate #2 for the version
> > > 3.1.0
> > > > >> of Apache Flink Stateful Functions, as follows:
> > > > >> [ ] +1, Approve the release
> > > > >> [ ] -1, Do not approve the release (please provide specific
> > comments)
> > > > >>
> > > > >> **Testing Guideline**
> > > > >>
> > > > >> You can find here [1] a page in the project wiki on instructions
> for
> > > > >> testing.
> > > > >> To cast a vote, it is not necessary to perform all listed checks,
> > > > >> but please mention which checks you have performed when voting.
> > > > >>
> > > > >> **Release Overview**
> > > > >>
> > > > >> As an overview, the release consists of the following:
> > > > >> a) Stateful Functions canonical source distribution, to be
> deployed
> > to
> > > > >> the release repository at dist.apache.org
> > > > >> b) Stateful Functions Python SDK distributions to be deployed to
> > PyPI
> > > > >> c) Maven artifacts to be deployed to the Maven Central Repository
> > > > >> d) New Dockerfiles for the release
> > > > >> e) GoLang SDK tag statefun-sdk-go/v3.1.0-rc2
> > > > >>
> > > > >> **Staging Areas to Review**
> > > > >>
> > > > >> The staging areas containing the above mentioned artifacts are as
> > > > >> follows, for your review:
> > > > >> * All artifacts for a) and b) can be found in the corresponding
> dev
> > > > >> repository at dist.apache.org [2]
> > > > >> * All artifacts for c) can be found at the Apache Nexus Repository
> > [3]
> > > > >>
> > > > >> All artifacts are signed with the key
> > > > >> 73BC0A2B04ABC80BF0513382B0ED0E338D622A92 [4]
> > > > >>
> > > > >> Other links for your review:
> > > > >> * JIRA release notes [5]
> > > > >> * source code tag "release-3.1.0-rc2" [6]
> > > > >> * PR for the new Dockerfiles [7]
> > > > >>
> > > > >> **Vote Duration**
> > > > >>
> > > > >> The voting time will run for at least 72 hours (since RC1). We are
> > > > >> targeting this vote to last until Thursday. 26th of August, 6pm
> CET.
> > > > >> If it is adopted by majority approval, with at least 3 PMC
> > affirmative
> > > > >> votes, it will be released.
> > > > >>
> > > > >> Thanks,
> > > > >> Igal
> > > > >>
> > > > >> [1]
> > > > >>
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Stateful+Functions+Release
> > > > >> [2]
> > > > >>
> > > https://dist.apache.org/repos/dist/dev/flink/flink-statefun-3.1.0-rc2/
> > > > >> [3]
> > > > >>
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1446/
> > > > >> [4] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > >> [5]
> > > > >>
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350038&projectId=12315522
> > > > >> [6]
> https://github.com/apache/flink-statefun/tree/release-3.1.0-rc2
> > > > >> [7] https://github.com/apache/flink-statefun-docker/pull/15
> > > > >>
> > > > >>
> > > >
> > >
> >
>

Reply via email to