+1 (non-binding)

- Check if checksums and GPG files match the corresponding release files
- staging repository looks fine
- Start a local cluster (start-cluster.sh), logs fine
- Run sql-client and run a job, looks fine

I found an unexpected log in sql-client:
"Searching for
'/Users/lijingsong/Downloads/tmp/flink-1.13.2/conf/sql-client-defaults.yaml'...not
found"
This log should be removed. I created a JIRA for this:
https://issues.apache.org/jira/browse/FLINK-23552
(This should not be a blocker)

Best,
Jingsong

On Thu, Jul 29, 2021 at 10:44 PM Robert Metzger <rmetz...@apache.org> wrote:

> Thanks a lot for creating this release candidate
>
> +1 (binding)
>
> - staging repository looks fine
> - Diff to 1.13.1 looks fine wrt to dependency changes:
> https://github.com/apache/flink/compare/release-1.13.1...release-1.13.2-rc3
> - standalone mode works locally
>    - I found this issue, which is not specific to 1.13.2:
> https://issues.apache.org/jira/browse/FLINK-23546
> - src archive signature is matched; sha512 is correct
>
> On Thu, Jul 29, 2021 at 9:10 AM Zakelly Lan <zakelly....@gmail.com> wrote:
>
> > +1 (non-binding)
> >
> > * Built from source.
> > * Run wordcount datastream job on yarn
> > * Web UI and checkpoint seem good.
> > * Kill a container to make job failover, everything is good.
> > * Try run job from checkpoint, everything is good.
> >
> > On Fri, Jul 23, 2021 at 10:04 PM Yun Tang <myas...@live.com> wrote:
> >
> > > Hi everyone,
> > > Please review and vote on the release candidate #3 for the version
> > 1.13.2,
> > > as follows:
> > > [ ] +1, Approve the release
> > > [ ] -1, Do not approve the release (please provide specific comments)
> > >
> > >
> > > The complete staging area is available for your review, which includes:
> > > * JIRA release notes [1],
> > > * the official Apache source release and binary convenience releases to
> > be
> > > deployed to dist.apache.org [2], which are signed with the key with
> > > fingerprint 78A306590F1081CC6794DC7F62DAD618E07CF996 [3],
> > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > * source code tag "release-1.13.2-rc3" [5],
> > > * website pull request listing the new release and adding announcement
> > > blog post [6].
> > >
> > > The vote will be open for at least 72 hours. It is adopted by majority
> > > approval, with at least 3 PMC affirmative votes.
> > >
> > > Best,
> > > Yun Tang
> > >
> > > [1]
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350218&styleName=&projectId=12315522
> > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.13.2-rc3/
> > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > [4]
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1439/
> > > [5] https://github.com/apache/flink/releases/tag/release-1.13.2-rc3
> > > [6] https://github.com/apache/flink-web/pull/453
> > >
> > >
> >
>


-- 
Best, Jingsong Lee

Reply via email to