Thanks for your input, team. Good catch, Chesney. Till, we will address said comments.
All in all now we can close the vote successfully with the binding +1 votes of Gyula, Konstantin and Till. On Mon, Jul 12, 2021 at 10:42 AM Till Rohrmann <trohrm...@apache.org> wrote: > Thanks for starting the vote Marton. > > I have two comments: > > * I would suggest that the interfaces return Optional<ChannelHandler> or > at least have a @Nullable annotation in order to make the contract explicit. > * The test plan should contain tests for the general infrastructure which > should live in Flink. We should test that factories are loaded and that the > handlers are set up in the correct order. > > I would consider these two changes to the original FLIP small. I give > my +1 (binding) conditionally under the assumption that the comments will > be addressed. > > Cheers, > Till > > On Mon, Jul 12, 2021 at 10:15 AM Konstantin Knauf <kna...@apache.org> > wrote: > >> +1 (binding) >> >> Assuming that we continue to vote in this thread for now. >> >> Thank you for your patience! >> >> On Mon, Jul 12, 2021 at 8:56 AM Chesnay Schepler <ches...@apache.org> >> wrote: >> >> > The vote has not reached the required number of votes to be considered >> > successful. >> > >> > As outlined in the bylaws >> > < >> > >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=120731026#FlinkBylaws-Actions >> > >> > >> > FLIP votes require 3 binding +1 votes (i.e., from committers). >> > >> > On 10/07/2021 16:13, Márton Balassi wrote: >> > > Hi team, >> > > >> > > Thank you for your input, I am closing this vote as successful. >> > > Austin: thank you, I have added the experimental annotation >> explicitly to >> > > the FLIP. >> > > >> > > On Tue, Jul 6, 2021 at 5:17 PM Gabor Somogyi < >> gabor.g.somo...@gmail.com> >> > > wrote: >> > > >> > >> +1 (non-binding) >> > >> The @Experimental annotation is really missing, Marton could you add >> it >> > >> please? >> > >> >> > >> >> > >> On Tue, Jul 6, 2021 at 5:04 PM Austin Cawley-Edwards < >> > >> austin.caw...@gmail.com> wrote: >> > >> >> > >>> Hi Márton, >> > >>> >> > >>> The FLIP looks generally good to me, though could we add the >> > >>> `@Experimental` annotation to the proposed interfaces so it is in >> sync >> > >> with >> > >>> what was agreed in the discussion thread? >> > >>> >> > >>> Thanks, >> > >>> Austin >> > >>> >> > >>> On Tue, Jul 6, 2021 at 9:40 AM Gyula Fóra <gyf...@apache.org> >> wrote: >> > >>> >> > >>>> +1 from my side >> > >>>> >> > >>>> This is a good addition that will open many possibilities in the >> > future >> > >>> and >> > >>>> solve some immediate issues with the current Kerberos integration. >> > >>>> >> > >>>> Gyula >> > >>>> >> > >>>> On Tue, Jul 6, 2021 at 2:50 PM Márton Balassi < >> > >> balassi.mar...@gmail.com> >> > >>>> wrote: >> > >>>> >> > >>>>> Hi everyone, I would like to start a vote on FLIP-181 [1] which >> was >> > >>>>> discussed in this thread [2]. The vote will be open for at least >> 72 >> > >>> hours >> > >>>>> until July 9th unless there is an objection or not enough votes. >> > >>>>> >> > >>>>> [1] https://cwiki.apache.org/confluence/x/CAUBCw >> > >>>>> [2] >> > >>>>> >> > >>>>> >> > >> >> > >> https://lists.apache.org/thread.html/r53b6b8931b6248a849855dad27b1a431e55cdd48ca055910e8f015a8%40%3Cdev.flink.apache.org%3E >> > >> > >> > >> >> -- >> >> Konstantin Knauf >> >> https://twitter.com/snntrable >> >> https://github.com/knaufk >> >
