Hi Steffen, Thanks for writing down the proposal. Back when the new Sink API was being discussed, I was proposing to add our usual `CompletableFuture<Void> isAvailable()` pattern to make sinks non-blocking. You can see the discussion starting here [1], and continuing for a couple of more posts until here [2]. Back then, the outcome was that it would give very little benefit, at the expense of making the API more complicated. Could you maybe relate your proposal to that discussion from last year?
I see that your proposal is going much further than just adding the availability method, could you also motivate this a bit further? Could you maybe reference/show some sinks that: 1. are already implemented using FLIP-143 2. that have some code duplication... 3. ...this duplication would be solved by FLIP-171 Best, Piotrek [1] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-143-Unified-Sink-API-tp44602p44872.html [2] http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-143-Unified-Sink-API-tp44602p44930.html śr., 9 cze 2021 o 09:49 Hausmann, Steffen <shau...@amazon.de.invalid> napisał(a): > Hi there, > > We would like to start a discussion thread on "FLIP-171: Async Sink" [1], > where we propose to create a common abstraction for destinations that > support async requests. This abstraction will make it easier to add > destinations to Flink by implementing a lightweight shim, while it avoids > maintaining dozens of independent sinks. > > Looking forward to your feedback. > > Cheers, Steffen > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-171%3A+Async+Sink > > > > Amazon Web Services EMEA SARL > 38 avenue John F. Kennedy, L-1855 Luxembourg > Sitz der Gesellschaft: L-1855 Luxemburg > eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284 > > Amazon Web Services EMEA SARL, Niederlassung Deutschland > Marcel-Breuer-Str. 12, D-80807 Muenchen > Sitz der Zweigniederlassung: Muenchen > eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, > USt-ID DE317013094 > > > >
