Dear devs,

In the last couple of weeks, I have noticed that we are slacking a bit on
the components in PR/commit messages. I'd like to gather some feedback if
we still want to include them and if so, how we can improve the process of
finding the correct label.

My personal opinion: So far, I have usually added the component because
it's in the coding guidelines. I have not really understood the benefit. It
might be coming from a time where git support in IDE was lacking and it was
necessary to maintain an overview. I also have a hard time to find the
correct component at times; I often just repeat the component that I find
in a blame. Nevertheless, I value consistency over personal taste and would
stick to the plan (and guide contributions towards it) if other devs
(especially committers) do it as well. But this has been causing some
friction in a couple of reviews for me.

Could you please give your opinion on this matter? I think it's important
to note that if long-term committers are not following it, it's really hard
for newer devs to follow that (git blame not helping in choosing the
component). Then we should remove it from the guidelines to make
contributions easier.

Thanks

Arvid

Reply via email to