+1 (binding) - started cluster, ran example job on macos - sources look fine - Eyeballed the diff: https://github.com/apache/flink/compare/release-1.12.2...release-1.12.3-rc1. According to "git diff release-1.12.2...release-1.12.3-rc1 '*.xml'", there was only one external dependency change (snappy-java, which seems to be properly reflected in the NOTICE file) - the last CI run of the "release-1.12" branch is okay-ish: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=17315&view=results (this one failure occurred: https://issues.apache.org/jira/browse/FLINK-20950)
On Tue, Apr 27, 2021 at 5:03 PM Dawid Wysakowicz <dwysakow...@apache.org> wrote: > +1 (binding) > > - Verified checksums and signatures > - Reviewed the website PR > - Built from sources > - verified dependency version upgrades and updates in NOTICE files > compared to 1.12.2 > - started cluster and run WordCount example in BATCH mode and everything > looked good > > On 23/04/2021 23:52, Arvid Heise wrote: > > Hi everyone, > > Please review and vote on the release candidate #1 for the version > 1.12.3, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > The complete staging area is available for your review, which includes: > > * JIRA release notes [1], > > * the official Apache source release and binary convenience releases to > be > > deployed to dist.apache.org [2], which are signed with the key with > > fingerprint 476DAA5D1FF08189 [3], > > * all artifacts to be deployed to the Maven Central Repository [4], > > * source code tag "release-1.2.3-rc3" [5], > > * website pull request listing the new release and adding announcement > blog > > post [6]. > > > > The vote will be open for at least 72 hours. It is adopted by majority > > approval, with at least 3 PMC affirmative votes. > > > > Thanks, > > Your friendly release manager Arvid > > > > [1] > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12349691 > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.3-rc1/ > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > [4] > https://repository.apache.org/content/repositories/orgapacheflink-1419 > > [5] https://github.com/apache/flink/releases/tag/release-1.12.3-rc1 > > [6] https://github.com/apache/flink-web/pull/437 > > > >
