Chesnay Schepler created FLINK-21340:
----------------------------------------
             Summary: CheckForbiddenMethodsUsage is not run and fails
                 Key: FLINK-21340
                 URL: https://issues.apache.org/jira/browse/FLINK-21340
             Project: Flink
          Issue Type: Sub-task
          Components: Tests
            Reporter: Chesnay Schepler
             Fix For: 1.13.0


This seems to be intended as a manual test, that checks that certain methods 
are not being used.

It currently fails for 35 instances, 26 of which are for classes from 
flink-shaded (i.e., out of our control).

We should either adjust the test it ignore flink-shaded and fix the remaining 
issues, or remove the test.

flink-shaded classes could be ignored pretty easily like this:
{code}
            methodUsages.removeIf(
                    memberUsage ->
                            memberUsage
                                    .getDeclaringClass()
                                    .getPackageName()
                                    .startsWith("org.apache.flink.shaded"));
{code}

These are the remaining failures:
{code}
private static void 
org.apache.flink.api.common.typeutils.TypeSerializerSerializationUtilTest.modifySerialVersionUID(byte[],java.lang.String,long)
 throws java.lang.Exception
public void 
org.apache.flink.util.IOUtilsTest.testTryReadFullyFromLongerStream() throws 
java.io.IOException
public void 
org.apache.flink.core.io.PostVersionedIOReadableWritableTest.testReadNonVersionedWithLongPayload()
 throws java.io.IOException
public void 
org.apache.flink.streaming.api.operators.AbstractStreamOperatorTest.testCustomRawKeyedStateSnapshotAndRestore()
 throws java.lang.Exception
public void 
org.apache.flink.util.IOUtilsTest.testTryReadFullyFromShorterStream() throws 
java.io.IOException
public void 
org.apache.flink.core.io.PostVersionedIOReadableWritableTest.testReadVersioned()
 throws java.io.IOException
private 
org.apache.flink.runtime.checkpoint.channel.ChannelStateWriter$ChannelStateWriteResult
 
org.apache.flink.runtime.state.ChannelPersistenceITCase.write(long,java.util.Map,java.util.Map)
 throws java.lang.Exception
public void 
org.apache.flink.core.memory.HybridOnHeapMemorySegmentTest.testReadOnlyByteBufferPut()
private static org.apache.flink.runtime.state.IncrementalRemoteKeyedStateHandle 
org.apache.flink.runtime.state.IncrementalRemoteKeyedStateHandleTest.create(java.util.Random)
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to