@Ufuk, I also don't find any existing options with underscores in their keys. However, I do not find any explicit rules forbid using them either. I'm not saying this should block the FLIP. Just it would be nice to beware of this issue, and maybe ensure the assumption with test cases if we finally decide to go with these mapping rules.
Thank you~ Xintong Song On Tue, Jan 26, 2021 at 7:27 PM Ufuk Celebi <u...@apache.org> wrote: > @Xingtong: The assumption for the mapping was that we only have dots and > hyphens in the keys. Do you have an example for a key which include > underscores? If underscores are common for keys (I couldn't find any > existing options that use it), it would certainly be a blocker for the > discussed approach. > > On Tue, Jan 26, 2021, at 11:46 AM, Xintong Song wrote: > > - The naming conversions proposed in the FLIP seems not bijective to > me. > > There could be problems if the configuration key contains underscores. > > - a_b -> FLINK_CONFIG_a_b > > - FLINK_CONFIG_a_b -> a.b >
