Thanks, Ufuk. I think that makes sense, so I moved it from a footnote to an
addition to prevent that in the future as well.

Ingo

On Fri, Jan 22, 2021 at 3:10 PM Ufuk Celebi <u...@apache.org> wrote:

> LGTM. Let's see what the others think...
>
> On Thu, Jan 21, 2021, at 11:37 AM, Ingo Bürk wrote:
> > Regarding env.java.opts, what special handling is needed there? AFAICT
> only
> > the rejected alternative of substituting values would've had an effect on
> > this.
>
> Makes sense 👍
>
> From the FLIP:
> > This mapping is not strictly bijective, but cases with consecutive
> periods or dashes in the key name are not considered here and should not
> (reasonably) be allowed.
>
> We could actually enforce such restrictions in the implementation of
> ConfigOption, avoiding any surprises down the line.
>
> – Ufuk
>

Reply via email to