Great! Thanks Aljoscha and Chesnay for driving this. Thank you~
Xintong Song On Tue, Dec 29, 2020 at 1:28 AM Chesnay Schepler <ches...@apache.org> wrote: > Hello everyone, > > I have just merged the commits for FLINK-20651 > <https://issues.apache.org/jira/browse/FLINK-20651> to master, > release-1.12 and release-11, which enforces new formatting rules using > the spotless plugin, following the google-java-format. > > This change touched every single java file in the repository, > predominantly due to switching from tabs to spaces. This implies that > every PR and WIP branch will require a rebase. > > > Most of the changes were done by a single commit, which you can exclude > from git blame by configuring git as follows (note that this requires > git 2.23+, and also works for IntelliJ): > > git config blame.ignoreRevsFile .git-blame-ignore-revs > > > You can setup the IDE to follow the new code style as follows: > > 1. Install the google-java-format plugin > <https://plugins.jetbrains.com/plugin/8527-google-java-format> and > enable it for the project > 2. In the plugin settings, change the code style to "AOSP" (4-space > indents) > 3. Install the Save Actions plugin > <https://plugins.jetbrains.com/plugin/7642-save-actions> > 4. Enable the plugin, along with "Optimize imports" and "Reformat file" > > To manually apply the formatting, run: > > mvn com.diffplug.spotless:spotless-maven-plugin:apply > > > Please be on the lookout for any suspicious formatting, outdated > instructions or other inconveniences. > > > Finally, a big thank you to Aljoscha for pushing this topic and finally > bringing it to an end. > >
