+1 (non-binding) - check checksum and signature - build source code with tests and checkstyle included - use sql-client testing some sql jobs, and the results are as expected.
Best, Hailong At 2020-12-16 22:50:34, "Timo Walther" <twal...@apache.org> wrote: >+1 (binding) > >I manually scanned the commit diff and checked for incompatible changes: > >- checked for changed @Public(Evolving) signatures >- checked for SQL plan changes >- checked for newly introduced features > >What I found a bit concerning is the large number of commits around the >new source API. I hope we don't break existing implementations due to >changed helper classes/interfaces. But I assume the new source API was >in beta/alpha phase anyways for 1.11. > >Regards, >Timo > > >On 16.12.20 13:15, Leonard Xu wrote: >> +1 (non-binding) >> >> - checked/verified signatures and hashes >> - built from source code with scala 2.11 succeeded >> - started a cluster, WebUI was accessible, submitted a wordcount job and ran >> succeeded >> - test simple sql job in SQL Client, the query result is expected >> >> Best, >> Leonard Xu >> >> >>> 在 2020年12月16日，20:02，Wei Zhong <weizhong0...@gmail.com> 写道： >>> >>> +1 (non-binding) >>> >>> - verified checksums and signatures >>> - pip install pyflink on Windows python 3.7 >>> - run a python job with udfs on Windows >>> >>> Best, >>> Wei >>> >>>> 在 2020年12月16日，15:51，Dian Fu <dian0511...@gmail.com> 写道： >>>> >>>> +1 (binding) >>>> >>>> - Verified the checksum and signature >>>> - Checked the pom changes since 1.11.2 for the dependencies changes and it >>>> looks good to me >>>> - Checked the website PR and left one minor comment >>>> >>>> Thanks, >>>> Dian >>>> >>>>> 在 2020年12月16日，下午3:00，Xintong Song <xts...@apache.org> 写道： >>>>> >>>>> +1 (non-binding) >>>>> >>>>> - Verified checksum and signature >>>>> - Source archive contains no binaries >>>>> - Built from source (scala 2.11, tests skipped) >>>>> - Run example jobs with various deployments modes >>>>> - Example jobs >>>>> - examples/streaming/WordCount.jar >>>>> - examples/streaming/WindowJoin.jar >>>>> - examples/batch/WordCount.jar >>>>> - Deployments >>>>> - Local (MiniCluster) >>>>> - Standalone >>>>> - Native Kubernetes Session/Application >>>>> - Yarn Session/Per-Job >>>>> - Verified >>>>> - WebUI looks good >>>>> - Logs look good >>>>> - Changing memory configurations works well >>>>> - Job recovers fine after killing taskmanager pod/container >>>>> (Native Kuberentes / Yarn) >>>>> >>>>> >>>>> On Wed, Dec 16, 2020 at 2:14 PM Yang Wang <danrtsey...@gmail.com> wrote: >>>>> >>>>>> +1 (non-binding) >>>>>> >>>>>> - Build from source with scala_2.11/2.12 >>>>>> - Test Flink deployment with Yarn and native K8s, verified the following >>>>>> critical bugs fixed >>>>>> - The provided lib could support non-qualified path, FLINK-20143 >>>>>> - Application mode could terminate normally in attach mode, FLINK-19909 >>>>>> - Application mode does not delete HA data in case of suspended >>>>>> ZooKeeper connection, FLINK-19154 >>>>>> - Checking the logs and webUI with no suspicious information >>>>>> >>>>>> >>>>>> Best, >>>>>> Yang >>>>>> >>>>>> Xingbo Huang <hxbks...@gmail.com> 于2020年12月16日周三 下午12:56写道： >>>>>> >>>>>>> +1 (non-binding) >>>>>>> >>>>>>> - verified checksums and signatures >>>>>>> - build Flink with Scala 2.11 >>>>>>> - pip install pyflink in MacOS under py37 >>>>>>> - test pyflink shell >>>>>>> - test cover FLINK-18836 and FLINK-19675 >>>>>>> >>>>>>> Best, >>>>>>> Xingbo >>>>>>> >>>>>>> Tzu-Li (Gordon) Tai <tzuli...@apache.org> 于2020年12月16日周三 下午12:29写道： >>>>>>> >>>>>>>> +1 (binding) >>>>>>>> >>>>>>>> - Verified signature and hashes >>>>>>>> - Verified that source artifact contains no binaries >>>>>>>> - Built from source (tests included) >>>>>>>> - Tested against StateFun, with a test job that covers >>>>>>>> https://issues.apache.org/jira/browse/FLINK-19741 >>>>>>>> >>>>>>>> Thanks for creating the RC Xintong! >>>>>>>> >>>>>>>> On Sun, Dec 13, 2020 at 9:37 AM Xintong Song <xts...@apache.org> wrote: >>>>>>>> >>>>>>>>> Hi everyone, >>>>>>>>> >>>>>>>>> We have resolved FLIP-27 issues. >>>>>>>>> >>>>>>>>> Please review and vote on the release candidate 21 for the version >>>>>>>> 1.11.3, >>>>>>>>> as follows: >>>>>>>>> >>>>>>>>> [ ] +1, Approve the release >>>>>>>>> [ ] -1, Do not approve the release (please provide specific comments) >>>>>>>>> >>>>>>>>> The complete staging area is available for your review, which >>>>>>> includes: >>>>>>>>> * JIRA release notes [1], >>>>>>>>> * the official Apache source release and binary convenience releases >>>>>>> to >>>>>>>> be >>>>>>>>> deployed to dist.apache.org [2], which are signed with the key with >>>>>>>>> fingerprint F8E419AA0B60C28879E876859DFF40967ABFC5A4 [3], >>>>>>>>> * all artifacts to be deployed to the Maven Central Repository [4], >>>>>>>>> * source code tag "release-1.11.3-rc2" [5], >>>>>>>>> * website pull request listing the new release and adding announcement >>>>>>>>> blog post [6]. >>>>>>>>> >>>>>>>>> The vote will be open for at least 72 hours. It is adopted by majority >>>>>>>>> approval, with at least 3 PMC affirmative votes. >>>>>>>>> >>>>>>>>> Thanks, Xintong Song >>>>>>>>> >>>>>>>>> [1] >>>>>>>>> >>>>>>>> >>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348761 >>>>>>>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.11.3-rc2 >>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>>>>>> [4] >>>>>>>> https://repository.apache.org/content/repositories/orgapacheflink-1407 >>>>>>>>> [5] https://github.com/apache/flink/releases/tag/release-1.11.3-rc2 >>>>>>>>> [6] https://github.com/apache/flink-web/pull/399 >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>> >>> >>
