+1 (binding)
Compiled source and ran all tests (JDK 8)
Ran example (greeter) with a docker compose setup
Release contains no binaries.
Checked LICENSE and NOTICE for source release
Checked LICENSE and NOTICE for flink-statefun-distribution binary release
On Fri, Nov 6, 2020 at 11:46 PM Igal Shilman <i...@ververica.com> wrote:
> +1 (non binding)
>
> Legal:
> - Checked signatures
> - Checked that no binaries were included in source artifacts
>
> Build
> - Built source `mvn clean install -Prun-e2e-tests` with jdk8
> - Built source mvn clean install -Prun-e2e-tests' with jdk11
> - Built the python SDK
> - Built the Docker Image
>
> Functional:
> - Verified that FLINK-19692 can no longer be reproduced.
> - Run a randomized smoke test ("random clicker"), with a high volume
> producer, and state verification in the presence of task manager failures.
> This program run successfully on this RC, and failed (as expected) on the
> previous version.
>
> Thanks,
> Igal.
>
> On Fri, Nov 6, 2020 at 9:48 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org>
> wrote:
>
> > +1 (binding)
> >
> > Legal:
> > - Checked signatures
> > - Checked that no binaries were included in source artifacts
> > - Build source `mvn clean install -Prun-e2e-tests`
> > - No dependency changes since 2.2.0, so assuming that NOTICE files are
> > correct (require no changes)
> >
> > Functional:
> > - Verified that FLINK-19692 can no longer be reproduced with a StateFun
> app
> > that deterministically floods the feedback loop with events. Run with a
> > docker-compose setup with parallelism=4, checkpointing to S3, verified
> for
> > all state backends.
> > - Checked that state bootstrap API by running the state bootstrap
> example,
> > and restoring the greeter example from the generated savepoint.
> >
> > On Thu, Nov 5, 2020 at 3:24 AM Robert Metzger <rmetz...@apache.org>
> wrote:
> >
> > > +1 binding
> > >
> > > Checks:
> > > - source sha and signature
> > > - mvn clean install passed on source archive
> > > - staging artifacts have correct version, also in quickstart, NOTICE
> > files
> > > seem correct
> > >
> > >
> > >
> > > On Wed, Nov 4, 2020 at 11:20 AM Tzu-Li (Gordon) Tai <
> tzuli...@apache.org
> > >
> > > wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > Please review and vote on the release candidate #1 for the version
> > 2.2.1
> > > of
> > > > Apache Flink Stateful Functions,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > > ***Testing Guideline***
> > > >
> > > > You can find here [1] a page in the project wiki on instructions for
> > > > testing.
> > > > To cast a vote, it is not necessary to perform all listed checks,
> > > > but please mention which checks you have performed when voting.
> > > >
> > > > ***Release Overview***
> > > >
> > > > As an overview, the release consists of the following:
> > > > a) Stateful Functions canonical source distribution, to be deployed
> to
> > > the
> > > > release repository at dist.apache.org
> > > > b) Stateful Functions Python SDK distributions to be deployed to PyPI
> > > > c) Maven artifacts to be deployed to the Maven Central Repository
> > > > d) New Dockerfiles for the release
> > > > e) Release announcement to be published to the Flink website
> > > >
> > > > ***Staging Areas to Review***
> > > >
> > > > The staging areas containing the above mentioned artifacts are as
> > > follows,
> > > > for your review:
> > > > * All artifacts for a) and b) can be found in the corresponding dev
> > > > repository at dist.apache.org [2]
> > > > * All artifacts for c) can be found at the Apache Nexus Repository
> [3]
> > > >
> > > > All artifacts are signed with the key
> > > > 1C1E2394D3194E1944613488F320986D35C33D6A [4]
> > > >
> > > > Other links for your review:
> > > > * JIRA release notes [5]
> > > > * source code tag "release-2.2.1-rc1" [6]
> > > > * PR for the new Dockerfiles [7]
> > > > * PR for the release announcement blog post [8]
> > > >
> > > > ***Vote Duration***
> > > >
> > > > The voting time will run for 72 hours, lasting until Nov. 7th, 10am
> > CET.
> > > > It is adopted by majority approval, with at least 3 PMC affirmative
> > > votes.
> > > >
> > > > Thanks,
> > > > Gordon
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Stateful+Functions+Release
> > > > [2]
> > > https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.2.1-rc1/
> > > > [3] https://repository.apache.org/content/repositories/org apache
> > > > flink-1401/
> > > > <
> > https://repository.apache.org/content/repositories/orgapacheflink-1401/
> > > >
> > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [5]
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12349291
> > > > [6]
> > > >
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=3d53612fccfe143acbdd1686a942b29c96c6bbd8
> > > > [7] https://github.com/apache/flink-statefun-docker/pull/11
> > > > [8] https://github.com/apache/flink-web/pull/389
> > > >
> > >
> >
>
