Thanks for the reminder Robert. I think you are completely right. Since we are getting closer to the feature freeze and therefore also the testing period, having green builds and only merging PRs where we are sure that CI passes will decrease the likelihood of introducing new bugs and, hence, it will decrease the time we need for hardening the release. Of course, this should also be the modus operandi for not only shortly before the feature freeze.
Cheers, Till On Mon, Oct 19, 2020 at 11:00 AM Robert Metzger <rmetz...@apache.org> wrote: > Hi folks, > > As we are approaching the final stages of the Flink 1.12 release cycle, I > would like to remind everybody to *only merge pull requests when the CI > system gives green light*! > I know that the CI system sometimes shows "FAILED" due to CI system > instabilities, but please carefully check those cases to make sure it is > really the CI systems fault, and not an unstable or failing test. > It is much easier to identify and fix an unstable or failing test in the > context of a pull request then after it's been merged. > > An essential part of keeping our CI system useful is helping to address > build instabilities early and proactively. > In this phase, I'll try to proactively revert commits introducing severe > issues, or disable failing/unstable tests early to keep the CI system > meaningful. > > Please post in this thread or reach out to me personally if you are > uncertain about a build failure or the overall state of the CI system. > > Best, > Robert >
