Zhu Zhu created FLINK-18355:
-------------------------------
Summary: Simplify tests of SlotPoolImpl
Key: FLINK-18355
URL: https://issues.apache.org/jira/browse/FLINK-18355
Project: Flink
Issue Type: Sub-task
Components: Runtime / Coordination, Tests
Reporter: Zhu Zhu
Fix For: 1.12.0
Tests of SlotPoolImpl, including SlotPoolImplTest, SlotPoolInteractionsTest and
SlotPoolSlotSharingTest, are somehow unnecessarily complicated in the code
involvement. E.g. SchedulerImp built on top of SlotPoolImpl is used to allocate
slots from SlotPoolImpl, which can be simplified by directly invoke slot
allocation on SlotPoolImpl.
Besides that, there are quite some duplications between tests classes of
SlotPoolImpl, this further includes SlotPoolPendingRequestFailureTest,
SlotPoolRequestCompletionTest and SlotPoolBatchSlotRequestTest.
It can ease future development and maintenance a lot if we clean up these tests
by
1. introduce a comment test base for fields and methods reuse
2. remove the usages of SchedulerImp for slotpool testing
3. other possible simplifications
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
