+1 to align the behavior to returning empty iterator. and I think this is what's the code style[1] said.
Best, Congxian Yu Li <car...@gmail.com> 于2020年5月11日周一 上午11:42写道： > +1 to align the behavior to returning empty iterator. There's no `Nullable` > annotation on the `MapState` interfaces, either. > > Best Regards, > Yu > > > On Mon, 11 May 2020 at 11:21, Pengfei Li <lpengfei2...@gmail.com> wrote: > > > +1 to align the behavior > > > > Jark Wu <imj...@gmail.com> 于2020年5月9日周六 下午9:36写道： > > > > > +1 to return emty iterator and align the implementations. > > > > > > Best, > > > Jark > > > > > > On Sat, 9 May 2020 at 19:18, SteNicholas <programg...@163.com> wrote: > > > > > > > Hi Tang Yun, > > > > I agree with the point you mentioned that align these internal > > > > behavior > > > > to return empty iterator instead of null. In my opinion, > > > > StateMapViewWithKeysNullable handle nullable map keys, and result of > > > > internal map state should be empty map in the null behavior case. > > > > Therefore, > > > > as you mentioned, #iterator() should better return empty iterator. > > > > > > > > Thanks, > > > > Nicholas Jiang > > > > > > > > > > > > > > > > -- > > > > Sent from: > > > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/ > > > > > > > > > >
