Thanks Yu! On Thu, May 7, 2020 at 7:44 AM Yu Li <car...@gmail.com> wrote:
> @Dawid Yes we will include it into RC3. Thanks for the note. > > @Till Thanks for the quick fix and the note. > > I've checked and confirmed there are no open issues under 1.10.1, neither > any resolved/closed ones under 1.10.2, so will start to prepare RC3. > > Best Regards, > Yu > > > On Wed, 6 May 2020 at 17:36, Till Rohrmann <trohrm...@apache.org> wrote: > > > I've merged the fix for FLINK-17514. > > > > Cheers, > > Till > > > > On Wed, May 6, 2020 at 10:53 AM Dawid Wysakowicz <dwysakow...@apache.org > > > > wrote: > > > > > Hi all, > > > > > > I wonder if we could also include FLINK-17313 which I backported into > > > 1.10 branch yesterday. > > > > > > Best, > > > > > > Dawid > > > > > > On 06/05/2020 07:26, Yu Li wrote: > > > > Thanks Till and Thomas, will include fix for both FLINK-17496 and > > > > FLINK-17514 in the next RC. > > > > > > > > Best Regards, > > > > Yu > > > > > > > > > > > > On Tue, 5 May 2020 at 22:10, Thomas Weise <t...@apache.org> wrote: > > > > > > > >> I opened a PR to backport the Kinesis fix - it would be nice to > > include > > > if > > > >> there is another RC: > > > >> > > > >> https://github.com/apache/flink/pull/11998 > > > >> > > > >> > > > >> On Tue, May 5, 2020 at 4:50 AM Till Rohrmann <trohrm...@apache.org> > > > wrote: > > > >> > > > >>> I've opened a PR for FLINK-17514. > > > >>> > > > >>> Cheers, > > > >>> Till > > > >>> > > > >>> On Tue, May 5, 2020 at 11:46 AM Yu Li <car...@gmail.com> wrote: > > > >>> > > > >>>> Thanks all for the efforts. > > > >>>> > > > >>>> I'm hereby canceling the vote due to FLINK-17514, will prepare > > another > > > >> RC > > > >>>> after the issue is fixed (hopefully soon). > > > >>>> > > > >>>> Best Regards, > > > >>>> Yu > > > >>>> > > > >>>> > > > >>>> On Tue, 5 May 2020 at 17:28, Till Rohrmann <trohrm...@apache.org> > > > >> wrote: > > > >>>>> I agree with Aljoscha. This is something we should fix since this > > is > > > >>> very > > > >>>>> important for Flink's stability. I will prepare a fix for the > > > >> problem. > > > >>>>> Cheers, > > > >>>>> Till > > > >>>>> > > > >>>>> On Tue, May 5, 2020 at 10:30 AM Congxian Qiu < > > qcx978132...@gmail.com > > > >>>>> wrote: > > > >>>>> > > > >>>>>> +1 （no-binding) > > > >>>>>> - sha and gpg, ok > > > >>>>>> - all pom files point to same version, ok > > > >>>>>> - build from souce, ok > > > >>>>>> - LICENCE, ok > > > >>>>>> - run demo in standalone cluster, ok > > > >>>>>> > > > >>>>>> Best, > > > >>>>>> Congxian > > > >>>>>> > > > >>>>>> > > > >>>>>> Aljoscha Krettek <aljos...@apache.org> 于2020年5月5日周二 下午3:50写道： > > > >>>>>> > > > >>>>>>> Unfortunately, I found this bug which prevents the > > > >>>> TaskCancelerWatchdog > > > >>>>>>> [sic] from working: > > > >>>> https://issues.apache.org/jira/browse/FLINK-17514. > > > >>>>> I > > > >>>>>>> think it's quite crucial that this failsafe mechanism works > > > >>>> correctly. > > > >>>>>>> We should cancel the release and fix it. > > > >>>>>>> > > > >>>>>>> Best, > > > >>>>>>> Aljoscha > > > >>>>>>> > > > >>>>>>> On 05.05.20 05:55, Hequn Cheng wrote: > > > >>>>>>>> Thanks a lot for managing the release! > > > >>>>>>>> > > > >>>>>>>> +1 (binding) > > > >>>>>>>> > > > >>>>>>>> - Go through all new commits for 1.10.1 and spot no new > license > > > >>>>>> problems. > > > >>>>>>>> - Built from source archive successfully. > > > >>>>>>>> - Signatures and hash are correct. > > > >>>>>>>> - Run SocketWindowWordCount on the local cluster. > > > >>>>>>>> - Install Python package and run Python WordCount example. > > > >>>>>>>> - Reviewed website PR > > > >>>>>>>> > > > >>>>>>>> Best, > > > >>>>>>>> Hequn > > > >>>>>>>> > > > >>>>>>>> On Sun, May 3, 2020 at 9:10 PM Robert Metzger < > > > >>> rmetz...@apache.org > > > >>>>>>> wrote: > > > >>>>>>>>> Thanks a lot for addressing the issues from the last release > > > >>>>> candidate > > > >>>>>>> and > > > >>>>>>>>> creating this one! > > > >>>>>>>>> > > > >>>>>>>>> +1 (binding) > > > >>>>>>>>> > > > >>>>>>>>> - Started Flink on YARN on Google Cloud DataProc by setting > > > >>>>>>>>> HADOOP_CLASSPATH > > > >>>>>>>>> - checked staging repo > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>> On Sat, May 2, 2020 at 6:57 PM Thomas Weise <t...@apache.org> > > > >>>> wrote: > > > >>>>>>>>>> +1 (binding) > > > >>>>>>>>>> > > > >>>>>>>>>> Checked signatures and hashes. > > > >>>>>>>>>> > > > >>>>>>>>>> Run internal benchmark applications. > > > >>>>>>>>>> > > > >>>>>>>>>> I found a regression that was actually introduced with > > > >> 1.10.0, > > > >>>>> hence > > > >>>>>>> not > > > >>>>>>>>> a > > > >>>>>>>>>> blocker for this release: > > > >>>>>>>>>> > > > >>>>>>>>>> https://github.com/apache/flink/pull/11975 > > > >>>>>>>>>> > > > >>>>>>>>>> Thanks, > > > >>>>>>>>>> Thomas > > > >>>>>>>>>> > > > >>>>>>>>>> > > > >>>>>>>>>> On Fri, May 1, 2020 at 5:37 AM Yu Li <car...@gmail.com> > > > >> wrote: > > > >>>>>>>>>>> Hi everyone, > > > >>>>>>>>>>> > > > >>>>>>>>>>> Please review and vote on the release candidate #2 for > > > >> version > > > >>>>>> 1.10.1, > > > >>>>>>>>> as > > > >>>>>>>>>>> follows: > > > >>>>>>>>>>> [ ] +1, Approve the release > > > >>>>>>>>>>> [ ] -1, Do not approve the release (please provide specific > > > >>>>>> comments) > > > >>>>>>>>>>> > > > >>>>>>>>>>> The complete staging area is available for your review, > > > >> which > > > >>>>>>> includes: > > > >>>>>>>>>>> * JIRA release notes [1], > > > >>>>>>>>>>> * the official Apache source release and binary convenience > > > >>>>> releases > > > >>>>>>> to > > > >>>>>>>>>> be > > > >>>>>>>>>>> deployed to dist.apache.org [2], which are signed with the > > > >>> key > > > >>>>> with > > > >>>>>>>>>>> fingerprint D8D3D42E84C753CA5F170BDF93C07902771AB743 [3], > > > >>>>>>>>>>> * all artifacts to be deployed to the Maven Central > > > >> Repository > > > >>>>> [4], > > > >>>>>>>>>>> * source code tag "release-1.10.1-rc2" [5], > > > >>>>>>>>>>> * website pull request listing the new release and adding > > > >>>>>> announcement > > > >>>>>>>>>> blog > > > >>>>>>>>>>> post [6]. > > > >>>>>>>>>>> > > > >>>>>>>>>>> The vote will be open for at least 72 hours. It is adopted > > > >> by > > > >>>>>> majority > > > >>>>>>>>>>> approval, with at least 3 PMC affirmative votes. > > > >>>>>>>>>>> > > > >>>>>>>>>>> Thanks, > > > >>>>>>>>>>> Yu > > > >>>>>>>>>>> > > > >>>>>>>>>>> [1] > > > >>>>>>>>>>> > > > >>>>>>>>>>> > > > >> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346891 > > > >>>>>>>>>>> [2] > > > >>>>> https://dist.apache.org/repos/dist/dev/flink/flink-1.10.1-rc2/ > > > >>>>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >>>>>>>>>>> [4] > > > >>>>>>>>>>> > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1363/ > > > >>>>>>>>>>> [5] > > > >>>>>>>>>>> > > > >>>>>>>>>>> > > > >> > > > > > > https://github.com/apache/flink/commit/f92e8a9d60ef664acd66230da43c6f0a1cd87adc > > > >>>>>>>>>>> [6] https://github.com/apache/flink-web/pull/330 > > > >>>>>>>>>>> > > > >>>>>>> > > > > > > > > >
