+1. The API change sounds good to me.
Thanks,
Jiangjie (Becket) Qin
On Fri, May 1, 2020 at 10:25 PM Yu Li <car...@gmail.com> wrote:
> +1
>
> I could see there's a thorough discussion and the solution looks good.
> Thanks for driving this Yangze.
>
> Best Regards,
> Yu
>
>
> On Fri, 1 May 2020 at 21:34, Till Rohrmann <trohrm...@apache.org> wrote:
>
> > Thanks for updating the FLIP Yangze.
> >
> > +1 (binding)
> >
> > for the update.
> >
> > Cheers,
> > Till
> >
> > On Thu, Apr 30, 2020 at 4:34 PM Yangze Guo <karma...@gmail.com> wrote:
> >
> > > Hi, there.
> > >
> > > The "FLIP-108: Add GPU support in Flink"[1] is now working in
> > > progress. However, we met problems regarding class loader and
> > > dependency. For more details, you could look at the discussion[2]. The
> > > discussion thread is now converged and the solution is changing the
> > > RuntimeContext#getExternalResourceInfos, let it return
> > > ExternalResourceInfo and adding methods to ExternalResourceInfo
> > > interface.
> > >
> > > Since the solution involves changes in the Public API. We'd like to
> > > start a voting thread for it.
> > >
> > > The proposed change is:
> > >
> > > ```
> > > public interface RuntimeContext {
> > > /**
> > > * Get the specific external resource information by the
> > resourceName.
> > > */
> > > Set<ExternalResourceInfo> getExternalResourceInfos(String
> > > resourceName);
> > > }
> > > ```
> > >
> > > ```
> > > public interface ExternalResourceInfo {
> > > String getProperty(String key);
> > > Collection<String> getKeys();
> > > }
> > > ```
> > >
> > > The vote will be open for at least 72 hours. Unless there is an
> > objection,
> > > I will try to close it by May 4, 2020 14:00 UTC if we have received
> > > sufficient votes.
> > >
> > > [1]
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-108%3A+Add+GPU+support+in+Flink
> > > [2]
> > >
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-108-Problems-regarding-the-class-loader-and-dependency-td40893.html
> > >
> > > Best,
> > > Yangze Guo
> > >
> >
>
