Thanks for taking a look Chesnay. Then let me officially cancel the release:
-1 (binding) Another question that I had while checking the release was the "apache-flink-1.10.1.tar.gz" binary, which I suppose is the python distribution. It does not contain a LICENSE and NOTICE file at the root level (which is okay [1] for binary releases), but in the "pyflink/" directory. There is also a "deps/" directory, which contains a full distribution of Flink, without any license files. I believe it would be a little bit nicer to have the LICENSE and NOTICE file in the root directory (if the python wheels format permits) to make sure it is obvious that all binary release contents are covered by these files. [1] http://www.apache.org/legal/release-policy.html#licensing-documentation On Wed, Apr 29, 2020 at 11:10 AM Congxian Qiu <qcx978132...@gmail.com> wrote: > Thanks a lot for creating a release candidate for 1.10.1! > > +1 from my side > > checked > - md5/gpg, ok > - source does not contain any binaries, ok > - pom points to the same version 1.10.1, ok > - README file does not contain anything unexpected, ok > - maven clean package -DskipTests, ok > - maven clean verify, encounter a test timeout exception, but I think it > does not block the RC(have created an issue[1] to track it), > - run demos on a stand-alone cluster, ok > > [1] https://issues.apache.org/jira/browse/FLINK-17458 > Best, > Congxian > > > Robert Metzger <rmetz...@apache.org> 于2020年4月29日周三 下午2:54写道： > > > Thanks a lot for creating a release candidate for 1.10.1! > > > > I'm not sure, but I think found a potential issue in the release while > > checking dependency changes on the ElasticSearch7 connector: > > > > > https://github.com/apache/flink/commit/1827e4dddfbac75a533ff2aea2f3e690777a3e5e#diff-bd2211176ab6e7fa83ffeaa89481ff38 > > > > In this change, "com.carrotsearch:hppc" has been added to the shaded jar > ( > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1362/org/apache/flink/flink-sql-connector-elasticsearch7_2.11/1.10.1/flink-sql-connector-elasticsearch7_2.11-1.10.1.jar > > ), > > without including proper mention of that dependency in "META-INF/NOTICE". > > > > > > My checking notes: > > > > - checked the diff for dependency changes: > > > https://github.com/apache/flink/compare/release-1.10.0...release-1.10.1-rc1 > > (w/o > > < > https://github.com/apache/flink/compare/release-1.10.0...release-1.10.1-rc1(w/o > > > > release commit: > > > > > https://github.com/apache/flink/compare/release-1.10.0...0e2b520ec60cc11dce210bc38e574a05fa5a7734 > > ) > > - flink-connector-hive sets the derby version for test-scoped > > dependencies: > > > > > https://github.com/apache/flink/compare/release-1.10.0...release-1.10.1-rc1#diff-f4dbf40e8457457eb01ae22b53baa3ec > > - no NOTICE file found, but this module does not forward binaries. > > - kafka 0.10 minor version upgrade: > > > > > https://github.com/apache/flink/compare/release-1.10.0...release-1.10.1-rc1#diff-0287a3f3c37b454c583b6b56de1392e4 > > - NOTICE change found > > - ES7 changes shading: > > > > > https://github.com/apache/flink/compare/release-1.10.0...release-1.10.1-rc1#diff-bd2211176ab6e7fa83ffeaa89481ff38 > > - problem found > > - Influxdb version change > > > > > https://github.com/apache/flink/compare/release-1.10.0...release-1.10.1-rc1#diff-0d2cce4875b2804ab89c3343a7de1ca6 > > - NOTICE change found > > > > > > > > On Fri, Apr 24, 2020 at 8:10 PM Yu Li <car...@gmail.com> wrote: > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #1 for version 1.10.1, > as > > > follows: > > > [ ] +1, Approve the release > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > > The complete staging area is available for your review, which includes: > > > * JIRA release notes [1], > > > * the official Apache source release and binary convenience releases to > > be > > > deployed to dist.apache.org [2], which are signed with the key with > > > fingerprint D8D3D42E84C753CA5F170BDF93C07902771AB743 [3], > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > * source code tag "release-1.10.1-rc1" [5], > > > * website pull request listing the new release and adding announcement > > blog > > > post [6]. > > > > > > The vote will be open for at least 72 hours. It is adopted by majority > > > approval, with at least 3 PMC affirmative votes. > > > > > > Thanks, > > > Yu > > > > > > [1] > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346891 > > > < > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346891 > > > > > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.10.1-rc1/ > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > [4] > > > > https://repository.apache.org/content/repositories/orgapacheflink-1362/ > > > [5] > > > > > > > > > https://github.com/apache/flink/commit/84b74cc0e21981bf6feceb74b48d7a9d3e215dc5 > > > [6] https://github.com/apache/flink-web/pull/330 > > > > > >
