This FLIP seems to be quite straightforward, +1 from my side. Best, Kurt
On Tue, Apr 7, 2020 at 8:42 PM Zhenghua Gao <doc...@gmail.com> wrote: > forward the reply to ML too. > > > *Best Regards,* > *Zhenghua Gao* > > > ---------- Forwarded message --------- > From: Zhenghua Gao <doc...@gmail.com> > Date: Tue, Apr 7, 2020 at 8:40 PM > Subject: Re: [DISCUSS] FLIP-71 - E2E View support in Flink SQL > To: godfrey he <godfre...@gmail.com> > > > >> regarding to "Interoperability between Flink and Hive is not > guaranteed", can you explain this more? > We have several limitations of interoperability between flink objects and > hive objects (tables, functions, etc). > So we don't promise the interoperability of views between flink and hive > since a view is defined base on these objects. > > >> "CREATE VIEW [ IF NOT EXISTS ]" > This should be "CREATE VIEW [OR REPLACE]". > > >> "DESC" > It's a shortcut of "DESCRIBE" in SQL Client (See desc table xxx). > In DDL, we should only support "SHOW VIEWS" and "DESCRIBE VIEW xxx". > > I have updated the design doc, thanks. > > *Best Regards,* > *Zhenghua Gao* > > > On Tue, Apr 7, 2020 at 8:09 PM godfrey he <godfre...@gmail.com> wrote: > > > Hi Zhenghua, > > > > Thanks for driving this. It's one step forward that TableEnvironment > > supports more complete SQLs. > > I have a few minor questions: > > 1. regarding to "Interoperability between Flink and Hive is not > > guaranteed", can you explain this more? > > 2. regarding to "The Grammar", Calcite does not support "CREATE VIEW [ IF > > NOT EXISTS ]", instead supports "CREATE [OR REPLACE]". "SHOW VIEWS" and > > "DESCRIBE VIEW xx" are not supported now. Calcite does not support > describe > > an object through "DESC" . I think It's better this flip can support > "SHOW > > VIEWS" and "DESCRIBE VIEW xx". > > > > Best, > > Godfrey > > > > Zhenghua Gao <doc...@gmail.com> 于2020年4月3日周五 下午3:04写道： > > > >> Hi community, > >> > >> It's a long time since we started the discussion of supporting view in > >> FLINK SQL. > >> Flink also continues to move forward since then. > >> FLINK-10232 introduces the grammar and FLINK-12905 supports CatalogView > >> in blink planner. > >> The missing link is validate the view definition and store the > >> original/expanded text in the catalog. > >> I have updated the design doc of FLIP-71, > >> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-71%3A+E2E+View+support+in+FLINK+SQL > >> > >> Any comments and feedbacks are welcome and appreciated. Thanks. > >> > >> *Best Regards,* > >> *Zhenghua Gao* > >> > >> > >> On Tue, Sep 17, 2019 at 11:51 AM Zhenghua Gao <doc...@gmail.com> wrote: > >> > >>> Hi folks, > >>> > >>> In umbrella task FLINK-10232 we have introduced CREATE/DROP VIEW > grammar > >>> in our module flink-sql-parser. But we don't support view objects in > >>> neither blink planner nor old planner. > >>> > >>> I'd like to kick off a discussion on end to end view support in Flink > >>> SQL in blink planner. It's helpful to improve the usability of the > >>> framework for SQL users. > >>> > >>> > >>> > https://docs.google.com/document/d/14bx0t8wYH7_o4ChNkDoBFGn-i0T-Q7kUiOFvDd13_Fk/edit#heading=h.m031smarjj9p > >>> > >>> In short, it: > >>> - support define views and store them in catalog > >>> - support drop view definitions from catalog > >>> - support query views > >>> - support other view related DDLs > >>> > >>> Any comments and feedbacks are welcome and appreciated. Thanks. > >>> > >>> *Best Regards,* > >>> *Zhenghua Gao* > >>> > >> >
