+1 (non-binding) ** Functional ** - Building from source dist with end-to-end tests enabled (mvn clean verify -Prun-e2e-tests) passes (JDK 8) - Flink Harness works in IDE - Building Python SDK dist from source
On Mon, Apr 6, 2020 at 5:12 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org> wrote: > +1 (binding) > > ** Legal ** > - checksums and GPG files match corresponding release files > - Source distribution does not contain binaries, contents are sane (no > .git* / .travis* / generated html content files) > - Bundled source LICENSEs and NOTICE looks good. Mentions bundled > font-awesome, jquery dependency in docs and copied sources from fastutil ( > http://fastutil.di.unimi.it/) > - Bundled LICENSEs and NOTICE files for Maven artifacts looks good. > Artifacts that do bundle dependencies are: statefun-flink-distribution, > statefun-ridesharing-example-simulator, statefun-flink-core (copied > sources). All non-ASLv2 deps have license files explicitly bundled. > - Python SDK distributions (source and wheel) contain ASLv2 LICENSE and > NOTICE files (no bundled dependencies) > - All POMs / README / Python SDK setup.py / Dockerfiles / doc configs point > to same version “2.0.0” > - README looks good > > ** Functional ** > - Building from source dist with end-to-end tests enabled (mvn clean verify > -Prun-e2e-tests) passes (JDK 8) > - Generated quickstart from archetype looks good (correct POM / Dockerfile > / service file) > - Examples run: Java Greeter / Java Ridesharing / Python Greeter / Python > SDK Walkthrough > - Flink Harness works in IDE > - Test remote functions deployment mode with AWS ecosystem: remote Python > functions running in AWS Lambda behind AWS API Gateway, Java embedded > functions running in AWS ECS. Checkpointing enabled, randomly restarted > StateFun workers. > > On Fri, Apr 3, 2020 at 11:48 AM Tzu-Li (Gordon) Tai <tzuli...@apache.org> > wrote: > > > Hi everyone, > > > > Please review and vote on the *release candidate #6* for the > > version 2.0.0 of Apache Flink Stateful Functions, > > as follows: > > [ ] +1, Approve the release > > [ ] -1, Do not approve the release (please provide specific comments) > > > > **Testing Guideline** > > > > You can find here [1] a doc that we can use for collaborating testing > > efforts. > > The listed testing tasks in the doc also serve as a guideline in what to > > test for this release. > > If you wish to take ownership of a testing task, simply put your name > down > > in the "Checked by" field of the task. > > > > **Release Overview** > > > > As an overview, the release consists of the following: > > a) Stateful Functions canonical source distribution, to be deployed to > the > > release repository at dist.apache.org > > b) Stateful Functions Python SDK distributions to be deployed to PyPI > > c) Maven artifacts to be deployed to the Maven Central Repository > > > > **Staging Areas to Review** > > > > The staging areas containing the above mentioned artifacts are as > follows, > > for your review: > > * All artifacts for a) and b) can be found in the corresponding dev > > repository at dist.apache.org [2] > > * All artifacts for c) can be found at the Apache Nexus Repository [3] > > > > All artifacts are signed with the > > key 1C1E2394D3194E1944613488F320986D35C33D6A [4] > > > > Other links for your review: > > * JIRA release notes [5] > > * source code tag "release-2.0.0-rc6" [6] [7] > > * PR to update the website Downloads page to include Stateful Functions > > links [8] > > > > **Extra Remarks** > > > > * Part of the release is also official Docker images for Stateful > > Functions. This can be a separate process, since the creation of those > > relies on the fact that we have distribution jars already deployed to > > Maven. I will follow-up with this after these artifacts are officially > > released. > > * The Flink Website and blog post is also being worked on (by Marta) as > > part of the release, to incorporate the new Stateful Functions project. > We > > can follow up with a link to those changes afterwards in this vote > thread, > > but that would not block you to test and cast your votes already. > > * Since the Flink website changes are still being worked on, you will not > > yet be able to find the Stateful Functions docs from there. Here are the > > links [9] [10]. > > > > **Vote Duration** > > > > I propose to have the voting time for this RC to be 96 hours (including > > weekend) / 48 hours (excluding weekend). > > > > The voting time will therefore run until at least next *Tuesday, April 7, > > 05:00 UTC.* > > > > It is adopted by majority approval, with at least 3 PMC affirmative > votes. > > > > Thanks, > > Gordon > > > > [1] > > > https://docs.google.com/document/d/1P9yjwSbPQtul0z2AXMnVolWQbzhxs68suJvzR6xMjcs/edit?usp=sharing > > [2] > https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.0.0-rc6/ > > [3] > > https://repository.apache.org/content/repositories/orgapacheflink-1346/ > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > [5] > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346878 > > [6] > > > https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=31e4df4ebf09fd9e74ae4c49bcdff56230e089ce > > [7] https://github.com/apache/flink-statefun/tree/release-2.0.0-rc6 > > [8] https://github.com/apache/flink-web/pull/318 > > [9] https://ci.apache.org/projects/flink/flink-statefun-docs-master/ > > [10] > https://ci.apache.org/projects/flink/flink-statefun-docs-release-2.0/ > > > > TIP: You can create a `settings.xml` file with these contents: > > > > """ > > <settings> > > <activeProfiles> > > <activeProfile>flink-statefun-2.0.0</activeProfile> > > </activeProfiles> > > <profiles> > > <profile> > > <id>flink-statefun-2.0.0</id> > > <repositories> > > <repository> > > <id>flink-statefun-2.0.0</id> > > <url> > > https://repository.apache.org/content/repositories/orgapacheflink-1346/ > > </url> > > </repository> > > <repository> > > <id>archetype</id> > > <url> > > https://repository.apache.org/content/repositories/orgapacheflink-1346/ > > </url> > > </repository> > > </repositories> > > </profile> > > </profiles> > > </settings> > > """ > > > > And reference that in you maven commands via `--settings > > path/to/settings.xml`. > > This is useful for creating a quickstart based on the staged release and > > for building against the staged jars. > > > -- Konstantin Knauf | Head of Product +49 160 91394525 Follow us @VervericaData Ververica <https://www.ververica.com/> -- Join Flink Forward <https://flink-forward.org/> - The Apache Flink Conference Stream Processing | Event Driven | Real Time -- Ververica GmbH | Invalidenstrasse 115, 10115 Berlin, Germany -- Ververica GmbH Registered at Amtsgericht Charlottenburg: HRB 158244 B Managing Directors: Timothy Alexander Steinert, Yip Park Tung Jason, Ji (Tony) Cheng
