Hi,
+1 (non-binding) Thanks for driving this, Gary & Yu. - Verified signatures and checksums - Maven build from source skip tests - Start local cluster and web ui is accessible - Submit example of both batch and streaming, run well and log no exception. - Verified pom files point to the 1.10.0 version - Take a quick look to release note - Run examples of flink-example-table in IDE Retest Table TPC-DS 10T batch performance: - The performance is not regressed. - Some improvements because we put hive related jars to flink/lib. Hive integration: - Test hive related common features and test type support on the cluster. No problem. SQL client: - Common features work well. Best, Jingsong Lee On Fri, Jan 31, 2020 at 5:00 PM Aljoscha Krettek <aljos...@apache.org> wrote: > +1 (binding) > > - I verified the checksum > - I verified the signatures > - I eyeballed the diff in pom files between 1.9 and 1.10 and checked any > newly added dependencies. They are ok. If the 1.9 licensing was correct > the licensing on this should also be correct > - I manually installed Flink Python and ran the WordCount.py example on > a (local) cluster and standalone > > Aljoscha > > On 30.01.20 10:49, Piotr Nowojski wrote: > > Hi, > > > > Thanks for creating this RC Gary & Yu. > > > > +1 (non-binding) from my side > > > > Because of instabilities during the testing period, I’ve manually tested > some jobs (and streaming examples) on an EMR cluster, writing to S3 using > newly unshaded/not relocated S3 plugin. Everything seems to works fine. > Also I’m not aware of any blocking issues for this RC. > > > > Piotrek > > > >> On 27 Jan 2020, at 22:06, Gary Yao <g...@apache.org> wrote: > >> > >> Hi everyone, > >> Please review and vote on the release candidate #1 for the version > 1.10.0, > >> as follows: > >> [ ] +1, Approve the release > >> [ ] -1, Do not approve the release (please provide specific comments) > >> > >> > >> The complete staging area is available for your review, which includes: > >> * JIRA release notes [1], > >> * the official Apache source release and binary convenience releases to > be > >> deployed to dist.apache.org [2], which are signed with the key with > >> fingerprint BB137807CEFBE7DD2616556710B12A1F89C115E8 [3], > >> * all artifacts to be deployed to the Maven Central Repository [4], > >> * source code tag "release-1.10.0-rc1" [5], > >> > >> The announcement blog post is in the works. I will update this voting > >> thread with a link to the pull request soon. > >> > >> The vote will be open for at least 72 hours. It is adopted by majority > >> approval, with at least 3 PMC affirmative votes. > >> > >> Thanks, > >> Yu & Gary > >> > >> [1] > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12345845 > >> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.10.0-rc1/ > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >> [4] > https://repository.apache.org/content/repositories/orgapacheflink-1325 > >> [5] https://github.com/apache/flink/releases/tag/release-1.10.0-rc1 > > > -- Best, Jingsong Lee
