Hi Hequn, Thanks a lot for the quick update.
+1 (non-binding) - Verified signatures and checksums - Build from source without tests with Scala 2.11 and Scala 2.12 - Start local cluster and WebUI is accessible - Submit wordcount example of both batch and stream, there is no suspicious log output - Run a couple of tests in IDE - Verified that all POM files point to the right version - The release note and announcement PR looks good Regards, Dian > 在 2019年11月29日，下午4:20，Hequn Cheng <chenghe...@gmail.com> 写道： > > Hi Dian, > > Thanks a lot for the review and valuable feedback! I have addressed the > JIRA problems and updated the website PR. > It would be great if you can take another look. > > Best, > Hequn > > On Fri, Nov 29, 2019 at 2:21 PM Dian Fu <dian0511...@gmail.com> wrote: > >> Hi Hequn, >> >> Thanks a lot for the great work! >> >> I found the following minor issues: >> 1. The announcement PR for website has one minor issue. (Have left >> comments on the PR) >> 2. The following JIRAs are included 1.8.3, but the fix version are not >> updated and so not reflected in the release note: >> https://issues.apache.org/jira/browse/FLINK-14235 ( >> https://github.com/apache/flink/tree/e0387a8007707ab29795e3aa3794ad279eaaeaf9 >> ) >> https://issues.apache.org/jira/browse/FLINK-14370 ( >> https://github.com/apache/flink/tree/cf7509b91888e4c6b64eb514fbb62af49533e0f0 >> ) >> 3. The following JIRA is not included in 1.8.3, but the fix version is >> marked as fixed in 1.8.3 and so was included in the release note: >> https://issues.apache.org/jira/browse/FLINK-10377 >> >> Regards, >> Dian >> >>> 在 2019年11月28日，下午10:22，Hequn Cheng <chenghe...@gmail.com> 写道： >>> >>> Hi everyone, >>> >>> Please review and vote on the release candidate #1 for the version 1.8.3, >>> as follows: >>> [ ] +1, Approve the release >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> >>> The complete staging area is available for your review, which includes: >>> * JIRA release notes [1], >>> * the official Apache source release and binary convenience releases to >> be >>> deployed to dist.apache.org [2], which are signed with the key with >>> fingerprint EF88474C564C7A608A822EEC3FF96A2057B6476C [3], >>> * all artifacts to be deployed to the Maven Central Repository [4], >>> * source code tag "release-1.8.3-rc1" [5], >>> * website pull request listing the new release and adding announcement >> blog >>> post [6]. >>> >>> The vote will be open for at least 72 hours. >>> Please cast your votes before *Dec. 3rd 2019, 16:00 UTC*. >>> >>> It is adopted by majority approval, with at least 3 PMC affirmative >> votes. >>> >>> Thanks, >>> Hequn >>> >>> [1] >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346112 >>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.8.3-rc1/ >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>> [4] >> https://repository.apache.org/content/repositories/orgapacheflink-1310 >>> [5] >>> >> https://github.com/apache/flink/commit/cf92a34e3465d2898eecd2aa7c06d6dc17f60ba3 >>> [6] https://github.com/apache/flink-web/pull/285 >> >>
