Zhenghua Gao created FLINK-14810: ------------------------------------ Summary: It's weird that copy julianDateFloor from DateTimeUtils and change the implementation Key: FLINK-14810 URL: https://issues.apache.org/jira/browse/FLINK-14810 Project: Flink Issue Type: Improvement Components: Table SQL / Planner Reporter: Zhenghua Gao
In SqlDateTimeUtils we copied *julianToLocalDate* from DateTimeUtils and changed the implementation. It's weird to use an *entirely* *different* implementation to do the same thing. One possible improvement of the new one is support TimeUnitRange.QUARTER. But the logic to calculate year/month/day is totally different. -- This message was sent by Atlassian Jira (v8.3.4#803005)