Zili Chen created FLINK-14565:
---------------------------------
Summary: Shutdown SystemResourcesCounter on (JM|TM)MetricGroup
closed
Key: FLINK-14565
URL: https://issues.apache.org/jira/browse/FLINK-14565
Project: Flink
Issue Type: Bug
Components: Runtime / Metrics
Reporter: Zili Chen
Assignee: Zili Chen
Currently, we start SystemResourcesCounter when initialize (JM|TM)MetricGroup.
This thread doesn't exit on (JM|TM)MetricGroup closed and even there is not
exit logic of them.
It possibly causes thread leak. For example, on our platform which supports
previewing sample SQL execution, it starts a MiniCluster in the same process as
the platform. When the preview job finished MiniCluster closed and also
(JM|TM)MetricGroup. However these SystemResourcesCounter threads remain.
I propose when creating SystemResourcesCounter, track it in (JM|TM)MetricGroup,
and on (JM|TM)MetricGroup closed, shutdown SystemResourcesCounter. This way, we
survive from thread leaks.
CC [~chesnay] [~trohrmann]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
