Hi,
I really like the flip and think it clarifies important aspects of the
system.
I have two, I hope small suggestions, which will not take much time to
agree on.
1. Could we follow the MySQL approach in regards to the existence of cat/db
for temporary functions? That means not to check it, so e.g. it's possible
to create a temporary function in a database that does not exist. I think
it's really useful e.g in cases when user wants to perform experiments but
does not have access to the db yet or temporarily does not have connection
to a catalog.
2. Could we not change the ObjectIdentifier? Could we not loosen the
requirements for all catalog objects such as tables, views, types just for
the functions? It's really important later on from e.g the serializability
perspective. The important aspect of the ObjectIdentifier is that we know
that it has been resolved. The suggested changes break that assumption.
What do you think about adding an interface FunctionIdentifier {
String getName();
/**
Return 3-part identifier. Empty in case of a built-in function.
*/
Optional<ObjectIdentifier> getObjectIdentifier()
}
class ObjectIdentifier implements FunctionIdentifier {
Optional<ObjectIdentifier> getObjectIdentifier() {
return Optional.of(this);
}
}
class SystemFunctionIdentifier implements FunctionIdentifier {...}
WDYT?
On Wed, 25 Sep 2019, 04:50 Xuefu Z, <usxu...@gmail.com> wrote:
> +1. LGTM
>
> On Tue, Sep 24, 2019 at 6:09 AM Terry Wang <zjuwa...@gmail.com> wrote:
>
> > +1
> >
> > Best,
> > Terry Wang
> >
> >
> >
> > > 在 2019年9月24日，上午10:42，Kurt Young <ykt...@gmail.com> 写道：
> > >
> > > +1
> > >
> > > Best,
> > > Kurt
> > >
> > >
> > > On Tue, Sep 24, 2019 at 2:30 AM Bowen Li <bowenl...@gmail.com> wrote:
> > >
> > >> Hi all,
> > >>
> > >> I'd like to start a voting thread for FLIP-57 [1], which we've reached
> > >> consensus in [2].
> > >>
> > >> This voting will be open for minimum 3 days till 6:30pm UTC, Sep 26.
> > >>
> > >> Thanks,
> > >> Bowen
> > >>
> > >> [1]
> > >>
> > >>
> >
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-57%3A+Rework+FunctionCatalog
> > >> [2]
> > >>
> > >>
> >
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-57-Rework-FunctionCatalog-td32291.html#a32613
> > >>
> >
> >
>
> --
> Xuefu Zhang
>
> "In Honey We Trust!"
>
