+1, Overall looks good. Best, Terry Wang
> 在 2019年9月24日，下午5:02，Kurt Young <ykt...@gmail.com> 写道： > > +1 from my side. Some implementation details could be revisited > again during code reviewing. > > Best, > Kurt > > > On Tue, Sep 24, 2019 at 3:14 PM Jingsong Li <jingsongl...@gmail.com> wrote: > >> Just to clarify: >> >> FLIP wiki: >> >> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support >> >> >> Discussion thread: >> >> >> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html >> >> >> Google Doc: >> >> https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing >> >> Best, >> Jingsong Lee >> >> On Tue, Sep 24, 2019 at 11:43 AM Jingsong Lee <lzljs3620...@apache.org> >> wrote: >> >>> Thank you for your reminder. >>> Updated. >>> >>> Best, >>> Jingsong Lee >>> >>> On Tue, Sep 24, 2019 at 11:36 AM Kurt Young <ykt...@gmail.com> wrote: >>> >>>> Looks like the wiki is not aligned with latest google doc, could >>>> you update it first? >>>> >>>> Best, >>>> Kurt >>>> >>>> >>>> On Tue, Sep 24, 2019 at 10:19 AM Jingsong Lee <lzljs3620...@apache.org> >>>> wrote: >>>> >>>>> Hi Flink devs, after another round of discussion. >>>>> >>>>> I would like to re-start the voting for FLIP-63 >>>>> Rework table partition support. >>>>> >>>>> FLIP wiki: >>>>> < >>>>> >>>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-33%3A+Standardize+Connector+Metrics >>>>>> >>>>> < >>>>> >>>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-51%3A+Rework+of+the+Expression+Design >>>>>> >>>>> >>>>> >>>> >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support >>>>> >>>>> Discussion thread: >>>>> < >>>>> >>>> >> https://lists.apache.org/thread.html/65078bad6e04bbbb7578d502e1e5d92026f13fd9648725f5b74ed330@%3Cdev.flink.apache.org%3E >>>>>> >>>>> < >>>>> >>>> >> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-51-Rework-of-the-Expression-Design-td31653.html >>>>>> >>>>> >>>>> >>>> >> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-63-Rework-table-partition-support-td32770.html >>>>> >>>>> Google Doc: >>>>> < >>>>> >>>> >> https://docs.google.com/document/d/1yFDyquMo_-VZ59vyhaMshpPtg7p87b9IYdAtMXv5XmM/edit?usp=sharing >>>>>> >>>>> >>>>> >>>> >> https://docs.google.com/document/d/15R3vZ1R_pAHcvJkRx_CWleXgl08WL3k_ZpnWSdzP7GY/edit?usp=sharing >>>>> >>>>> Thanks, >>>>> >>>>> Best, >>>>> Jingsong Lee >>>>> >>>> >>> >>> >>> -- >>> Best, Jingsong Lee >>> >> >> >> -- >> Best, Jingsong Lee >>
