Great Job Jark :)
Best, Jincheng

Kurt Young <ykt...@gmail.com> 于2019年8月26日周一 下午6:38写道:

> Thanks for the updates, Jark! I have subscribed the ML and everything
> looks good now.
>
> Best,
> Kurt
>
>
> On Mon, Aug 26, 2019 at 11:17 AM Jark Wu <imj...@gmail.com> wrote:
>
> > Hi all,
> >
> > Sorry it take so long to get back. I have some good news.
> >
> > After some investigation and development and the help from Chesnay, we
> > finally integrated Travis build notification with
> bui...@flink.apache.org
> > mailing list with remaining the beautiful formatting!
> > Currently, only the failure and failure->success builds will be notified,
> > only builds (include CRON) on apache/flink branches will be notified, the
> > pull request builds will not be notified.
> >
> > The builds mailing list is also available in Flink website community page
> > [1]
> >
> > I would encourage devs to subscribe the builds mailing list, and help the
> > community to pay more attention to the build status, especially the CRON
> > builds.
> >
> > Feel free to leave your suggestions and feedbacks here!
> >
> > --------------------------------------------------------------------
> >
> > # The implementation detail:
> >
> > I implemented a flink-notification-bot[2] to receive Travis webhook[3]
> > payload and generate an HTML email and send the email to
> > bui...@flink.apache.org.
> > The flink-notification-bot is deployed on my own VM in DigitalOcean. You
> > can refer the github page [2] of the project to learn more details about
> > the implementation and deployment.
> > Btw, I'm glad to contribute the project to https://github.com/flink-ci
> or
> > https://github.com/flinkbot if the community accepts.
> >
> > With the flink-notification-bot, we can easily integrate it with other CI
> > service or our own CI, and we can also integrate it with some other
> > applications (e.g. DingTalk).
> >
> > # Rejected Alternative:
> >
> > Option#1: Sending email notifications via "Travis Email Notification"[4].
> > Reasons:
> >  - If the emailing notification is set, Travis CI only sends an emails to
> > the addresses specified there, rather than to the committer and author.
> >  - We will lose the beautiful email formatting when Travis send Email to
> > builds ML.
> >  - The return-path of emails from Travis CI is not constant, which makes
> it
> > difficult for mailing list to accept it.
> >
> > Cheers,
> > Jark
> >
> > [1]: https://flink.apache.org/community.html#mailing-lists
> > [2]: https://github.com/wuchong/flink-notification-bot
> > [3]:
> >
> >
> https://docs.travis-ci.com/user/notifications/#configuring-webhook-notifications
> > [4]:
> >
> >
> https://docs.travis-ci.com/user/notifications/#configuring-email-notifications
> >
> >
> >
> >
> > On Tue, 30 Jul 2019 at 18:35, Jark Wu <imj...@gmail.com> wrote:
> >
> > > Hi all,
> > >
> > > Progress updates:
> > > 1. the bui...@flink.apache.org can be subscribed now (thanks @Robert),
> > > you can send an email to builds-subscr...@flink.apache.org to
> subscribe.
> > > 2. We have a pull request [1] to send only apache/flink builds
> > > notifications and it works well.
> > > 3. However, all the notifications are rejected by the builds mailing
> list
> > > (the MODERATE mails).
> > >     I added & checked bui...@travis-ci.org to the subscriber/allow
> list,
> > > but still doesn't work. It might be recognized as spam by the mailing
> > list.
> > >     We are still trying to figure it out, and will update here if we
> have
> > > some progress.
> > >
> > >
> > > Thanks,
> > > Jark
> > >
> > >
> > >
> > > [1]: https://github.com/apache/flink/pull/9230
> > >
> > >
> > > On Thu, 25 Jul 2019 at 22:59, Robert Metzger <rmetz...@apache.org>
> > wrote:
> > >
> > >> The mailing list has been created, you can now subscribe to it.
> > >>
> > >> On Wed, Jul 24, 2019 at 1:43 PM Jark Wu <imj...@gmail.com> wrote:
> > >>
> > >> > Thanks Robert for helping out that.
> > >> >
> > >> > Best,
> > >> > Jark
> > >> >
> > >> > On Wed, 24 Jul 2019 at 19:16, Robert Metzger <rmetz...@apache.org>
> > >> wrote:
> > >> >
> > >> > > I've requested the creation of the list, and made Jark, Chesnay
> and
> > me
> > >> > > moderators of it.
> > >> > >
> > >> > > On Wed, Jul 24, 2019 at 1:12 PM Robert Metzger <
> rmetz...@apache.org
> > >
> > >> > > wrote:
> > >> > >
> > >> > > > @Jark: Yes, I will request the creation of a mailing list!
> > >> > > >
> > >> > > > On Tue, Jul 23, 2019 at 4:48 PM Hugo Louro <hmclo...@gmail.com>
> > >> wrote:
> > >> > > >
> > >> > > >> +1
> > >> > > >>
> > >> > > >> > On Jul 23, 2019, at 6:15 AM, Till Rohrmann <
> > trohrm...@apache.org
> > >> >
> > >> > > >> wrote:
> > >> > > >> >
> > >> > > >> > Good idea Jark. +1 for the proposal.
> > >> > > >> >
> > >> > > >> > Cheers,
> > >> > > >> > Till
> > >> > > >> >
> > >> > > >> >> On Tue, Jul 23, 2019 at 1:59 PM Hequn Cheng <
> > >> chenghe...@gmail.com>
> > >> > > >> wrote:
> > >> > > >> >>
> > >> > > >> >> Hi Jark,
> > >> > > >> >>
> > >> > > >> >> Good idea. +1!
> > >> > > >> >>
> > >> > > >> >>> On Tue, Jul 23, 2019 at 6:23 PM Jark Wu <imj...@gmail.com>
> > >> wrote:
> > >> > > >> >>>
> > >> > > >> >>> Thank you all for your positive feedback.
> > >> > > >> >>>
> > >> > > >> >>> We have three binding +1s, so I think, we can proceed with
> > >> this.
> > >> > > >> >>>
> > >> > > >> >>> Hi @Robert Metzger <rmetz...@apache.org> , could you
> create
> > a
> > >> > > >> request to
> > >> > > >> >>> INFRA for the mailing list?
> > >> > > >> >>> I'm not sure if this needs a PMC permission.
> > >> > > >> >>>
> > >> > > >> >>> Thanks,
> > >> > > >> >>> Jark
> > >> > > >> >>>
> > >> > > >> >>> On Tue, 23 Jul 2019 at 16:42, jincheng sun <
> > >> > > sunjincheng...@gmail.com>
> > >> > > >> >>> wrote:
> > >> > > >> >>>
> > >> > > >> >>>> +1
> > >> > > >> >>>>
> > >> > > >> >>>> Robert Metzger <rmetz...@apache.org> 于2019年7月23日周二
> > 下午4:01写道:
> > >> > > >> >>>>
> > >> > > >> >>>>> +1
> > >> > > >> >>>>>
> > >> > > >> >>>>> On Mon, Jul 22, 2019 at 10:27 AM Biao Liu <
> > >> mmyy1...@gmail.com>
> > >> > > >> >> wrote:
> > >> > > >> >>>>>
> > >> > > >> >>>>>> +1, make sense to me.
> > >> > > >> >>>>>> Mailing list seems to be a more "community" way.
> > >> > > >> >>>>>>
> > >> > > >> >>>>>> Timo Walther <twal...@apache.org> 于2019年7月22日周一
> 下午4:06写道:
> > >> > > >> >>>>>>
> > >> > > >> >>>>>>> +1 sounds good to inform people about instabilities or
> > >> other
> > >> > > >> >> issues
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>> Regards,
> > >> > > >> >>>>>>> Timo
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>>> Am 22.07.19 um 09:58 schrieb Haibo Sun:
> > >> > > >> >>>>>>>> +1. Sounds good.Letting the PR creators know the build
> > >> > results
> > >> > > >> >> of
> > >> > > >> >>>> the
> > >> > > >> >>>>>>> master branch can help to determine more quickly
> whether
> > >> > Travis
> > >> > > >> >>>>> failures
> > >> > > >> >>>>>> of
> > >> > > >> >>>>>>> their PR are an exact failure or because of the
> > >> instability of
> > >> > > >> >> test
> > >> > > >> >>>>> case.
> > >> > > >> >>>>>>> By the way, if the PR creator can abort their own
> Travis
> > >> > build,
> > >> > > I
> > >> > > >> >>>> think
> > >> > > >> >>>>>> it
> > >> > > >> >>>>>>> can improve the efficient use of Travis resources (of
> > >> course,
> > >> > > >> >> this
> > >> > > >> >>>>>>> discussion does not deal with this issue).
> > >> > > >> >>>>>>>>
> > >> > > >> >>>>>>>>
> > >> > > >> >>>>>>>> Best,
> > >> > > >> >>>>>>>> Haibo
> > >> > > >> >>>>>>>> At 2019-07-22 12:36:31, "Yun Tang" <myas...@live.com>
> > >> wrote:
> > >> > > >> >>>>>>>>> +1 sounds good, more people could be encouraged to
> > >> involve
> > >> > in
> > >> > > >> >>>> paying
> > >> > > >> >>>>>>> attention to failure commit.
> > >> > > >> >>>>>>>>>
> > >> > > >> >>>>>>>>> Best
> > >> > > >> >>>>>>>>> Yun Tang
> > >> > > >> >>>>>>>>> ________________________________
> > >> > > >> >>>>>>>>> From: Becket Qin <becket....@gmail.com>
> > >> > > >> >>>>>>>>> Sent: Monday, July 22, 2019 9:44
> > >> > > >> >>>>>>>>> To: dev <dev@flink.apache.org>
> > >> > > >> >>>>>>>>> Subject: Re: [DISCUSS] Setup a
> bui...@flink.apache.org
> > >> > > >> >> mailing
> > >> > > >> >>>> list
> > >> > > >> >>>>>>> for travis builds
> > >> > > >> >>>>>>>>>
> > >> > > >> >>>>>>>>> +1. Sounds a good idea to me.
> > >> > > >> >>>>>>>>>
> > >> > > >> >>>>>>>>> On Sat, Jul 20, 2019 at 7:07 PM Dian Fu <
> > >> > > >> >> dian0511...@gmail.com>
> > >> > > >> >>>>>> wrote:
> > >> > > >> >>>>>>>>>
> > >> > > >> >>>>>>>>>> Thanks Jark for the proposal, sounds reasonable for
> > me.
> > >> +1.
> > >> > > >> >>> This
> > >> > > >> >>>> ML
> > >> > > >> >>>>>>> could
> > >> > > >> >>>>>>>>>> be used for all the build notifications including
> > master
> > >> > and
> > >> > > >> >>> CRON
> > >> > > >> >>>>>> jobs.
> > >> > > >> >>>>>>>>>>
> > >> > > >> >>>>>>>>>>> 在 2019年7月20日,下午2:55,Xu Forward <
> > forwardxu...@gmail.com
> > >> >
> > >> > 写道:
> > >> > > >> >>>>>>>>>>>
> > >> > > >> >>>>>>>>>>> +1 ,Thanks jark for the proposal.
> > >> > > >> >>>>>>>>>>> Best
> > >> > > >> >>>>>>>>>>> Forward
> > >> > > >> >>>>>>>>>>>
> > >> > > >> >>>>>>>>>>> Jark Wu <imj...@gmail.com> 于2019年7月20日周六
> 下午12:14写道:
> > >> > > >> >>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> Hi all,
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> As far as I know, currently, email notifications
> of
> > >> > Travis
> > >> > > >> >>>> builds
> > >> > > >> >>>>>> for
> > >> > > >> >>>>>>>>>>>> master branch are sent to the commit author when a
> > >> build
> > >> > > >> >> was
> > >> > > >> >>>> just
> > >> > > >> >>>>>>>>>> broken or
> > >> > > >> >>>>>>>>>>>> still is broken. And there is no email
> notifications
> > >> for
> > >> > > >> >> CRON
> > >> > > >> >>>>>> builds.
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> Recently, we are suffering from compile errors for
> > >> > > >> >> scala-2.12
> > >> > > >> >>>> and
> > >> > > >> >>>>>>> java-9
> > >> > > >> >>>>>>>>>>>> which are only ran in CRON jobs. So I'm figuring
> > out a
> > >> > way
> > >> > > >> >> to
> > >> > > >> >>>> get
> > >> > > >> >>>>>>>>>>>> notifications of CRON builds (or all builds) to
> > quick
> > >> fix
> > >> > > >> >>>> compile
> > >> > > >> >>>>>>> errors
> > >> > > >> >>>>>>>>>>>> and failed cron tests.
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> After reaching out to @Chesnay Schepler <
> > >> > > >> >> ches...@apache.org>
> > >> > > >> >>>>>> (thanks
> > >> > > >> >>>>>>>>>> for
> > >> > > >> >>>>>>>>>>>> the helping), I know that we are using a Slack
> > >> channel to
> > >> > > >> >>>> receive
> > >> > > >> >>>>>> all
> > >> > > >> >>>>>>>>>>>> failed build notifications. However, IMO, email
> > >> > > >> >> notification
> > >> > > >> >>>>> might
> > >> > > >> >>>>>>> be a
> > >> > > >> >>>>>>>>>>>> better way than Slack channel to encourage more
> > >> people to
> > >> > > >> >> pay
> > >> > > >> >>>>>>> attention
> > >> > > >> >>>>>>>>>> on
> > >> > > >> >>>>>>>>>>>> the builds.
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> So I'm here to propose to setup a
> > >> > bui...@flink.apache.org
> > >> > > >> >>>>> mailing
> > >> > > >> >>>>>>> list
> > >> > > >> >>>>>>>>>> for
> > >> > > >> >>>>>>>>>>>> receiving build notifications. I also find that
> Beam
> > >> has
> > >> > > >> >> such
> > >> > > >> >>>>>> mailing
> > >> > > >> >>>>>>>>>> list
> > >> > > >> >>>>>>>>>>>> too[1]. After we have such a mailing list, we can
> > >> > integrate
> > >> > > >> >>> it
> > >> > > >> >>>> to
> > >> > > >> >>>>>>> travis
> > >> > > >> >>>>>>>>>>>> according to the travis doc[2].
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> What do you think? Do we need a formal vote for
> > this?
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> Best and thanks,
> > >> > > >> >>>>>>>>>>>> Jark
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>> [1]:
> https://beam.apache.org/community/contact-us/
> > >> > > >> >>>>>>>>>>>> [2]:
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>
> > >> > > >> >>>>>
> > >> > > >> >>>>
> > >> > > >> >>>
> > >> > > >> >>
> > >> > > >>
> > >> > >
> > >> >
> > >>
> >
> https://docs.travis-ci.com/user/notifications/#configuring-email-notifications
> > >> > > >> >>>>>>>>>>>> <
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>
> > >> > > >> >>>>>
> > >> > > >> >>>>
> > >> > > >> >>>
> > >> > > >> >>
> > >> > > >>
> > >> > >
> > >> >
> > >>
> >
> https://docs.travis-ci.com/user/notifications/#configuring-email-notifications
> > >> > > >> >>>>>>>>>>>> <
> > >> > > >> >>>>>>>>>>>>
> > >> > > >> >>>>>>>>>>
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>
> > >> > > >> >>>>>
> > >> > > >> >>>>
> > >> > > >> >>>
> > >> > > >> >>
> > >> > > >>
> > >> > >
> > >> >
> > >>
> >
> https://docs.travis-ci.com/user/notifications/#configuring-email-notifications
> > >> > > >> >>>>>>>>>>
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>>
> > >> > > >> >>>>>>
> > >> > > >> >>>>>
> > >> > > >> >>>>
> > >> > > >> >>>
> > >> > > >> >>
> > >> > > >>
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> >
>

Reply via email to