+1 for KCL 1.x changes only. I also think it would make sense to align FLIP-27 work and KCL 2.x related changes, since these will require a hardening cycle with extensive testing that is probably not practical to repeat.
On Tue, Aug 20, 2019 at 10:57 AM Bowen Li <bowenl...@gmail.com> wrote: > @Stephan @Becket kinesis connector currently is using KCL 1.9. Mass changes > are needed if we switch to KCL 2.x. I agree with Dyana that, since KCL 1.x > is also updated to Apache 2.0, we can just focus on upgrading to a newer > KCL 1.x minor version for now. > > On Tue, Aug 20, 2019 at 7:52 AM Dyana Rose <dyana.r...@salecycle.com> > wrote: > > > ok great, > > > > that's done, the PR is rebased and squashed on top of master and is > running > > through Travis > > > > https://github.com/apache/flink/pull/9494 > > > > Dyana > > > > On Tue, 20 Aug 2019 at 15:32, Tzu-Li (Gordon) Tai <tzuli...@apache.org> > > wrote: > > > > > Hi Dyana, > > > > > > Regarding your question on the Chinese docs: > > > Since the Chinese counterparts for the Kinesis connector documentation > > > isn't translated yet (see docs/dev/connectors/kinesis.zh.md), for now > > you > > > can simply just sync whatever changes you made to the English doc to > the > > > Chinese one as well. > > > > > > Cheers, > > > Gordon > > > > > >
