Yun Gao created FLINK-13531:
-------------------------------
Summary: Do not print log and call release if no requests should
be evicted in slot sharing
Key: FLINK-13531
URL: https://issues.apache.org/jira/browse/FLINK-13531
Project: Flink
Issue Type: Bug
Components: Runtime / Coordination
Affects Versions: 1.9.0
Reporter: Yun Gao
After adding the logic to bookkeeping the resource used in the shared slots,
the resource requests will be recorded inside the MultiTaskSlot and when the
underlying slot is allocated, all the resource requests will be checked if
there is over-subscription, if so, some requests will be failed.
In the current implementation, the code does not check the amount to fail
before printing the over-allocated debug log and tries to fail them. This
should not cause actual errors, but it will
# Print a debug log saying some requests will be failed even if no one to fail.
# If the total number of requests is 0 (This is possible if there already
AllocatedSlot before the first request), the _release_ method will be called.
Although it will do nothing with the current implementation (the slot is still
being created and not added to any other data structure), it may cause error if
the release logic changes in the future.
To fix this issue, we should add a explicit check on the number of requests to
fail.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
