+1 (binding) - checked signatures and hashes - built from source without skipping tests (without Hadoop, Scala 2.12) - no new dependencies were added since 1.8.0 - ran the end-to-end tests locally once, and in a loop specifically for Kafka tests (to cover FLINK-11987) - announcement PR for website looks good!
Cheers, Gordon On Mon, Jul 1, 2019 at 9:02 AM jincheng sun <sunjincheng...@gmail.com> wrote: > +1 (binding) > > With the following checks: > > - checked gpg signatures by `gpg --verify 181.asc flink-1.8.1-src.tgz` > [success] > - checked the hashes by `shasum -a 512 flink-1.8.1-src.tgz` [success] > - built from source by `mvn clean package -DskipTests` [success] > - download the `flink-core-1.8.1.jar` from `repository.apache.org` > [success] > - run the example(word count) in local [success] > > Cheers, > Jincheng > > Jark Wu <imj...@gmail.com> 于2019年6月30日周日 下午9:21写道： > > > +1 (non-binding) > > > > - built from source successfully > > - checked signatures and hashes > > - run a couple of end-to-end tests locally with success > > - started a cluster both for scala-2.11 and scala-2.12, ran examples, > WebUI > > is accessible, no suspicious log output > > - reviewed the release PR and left comments > > > > Cheers, > > Jark > > > > On Thu, 27 Jun 2019 at 22:40, Hequn Cheng <chenghe...@gmail.com> wrote: > > > > > Hi Jincheng, > > > > > > Thanks a lot for the release which contains so many fixes! > > > > > > I have done the following checks: > > > > > > Local Tests > > > - Built from source archive successfully. > > > - Signatures and hash are correct. > > > - All artifacts have been deployed to the maven central repository. > > > - Run WordCount(batch&streaming) on Local cluster successfully. > > > > > > Cluster Tests > > > Cluster environment: 7 nodes, jm 1024m, tm 4096m > > > Testing Jobs: WordCount(batch&streaming), DataStreamAllroundTestProgram > > > - Read and write hdfs file successfully. > > > - Run jobs on YARN(with or without session) successfully > > > - Job failover and recovery successfully > > > > > > PR review > > > - Left a minor comment. But I think it is not a blocker, we can just > > update > > > the PR directly. > > > > > > To sum up, I have not spotted any blockers, so +1(non-binding) from my > > > side. > > > > > > Best, Hequn > > > > > > On Tue, Jun 25, 2019 at 4:52 PM jincheng sun <sunjincheng...@gmail.com > > > > > wrote: > > > > > > > Hi everyone, > > > > > > > > Please review and vote on the release candidate 1 for Flink 1.8.1, as > > > > follows: > > > > > > > > [ ] +1, Approve the release > > > > [ ] -1, Do not approve the release (please provide specific comments) > > > > > > > > The complete staging area is available for your review, which > includes: > > > > * JIRA release notes [1], > > > > * the official Apache source release and binary convenience releases > to > > > be > > > > deployed to dist.apache.org [2], which are signed with the key with > > > > fingerprint 8FEA1EE9D0048C0CCC70B7573211B0703B79EA0E [3], > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > * source code tag "release-1.8.1-rc1" [5], > > > > * website pull request listing the new release [6] > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > majority > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > Cheers, > > > > Jincheng > > > > > > > > [1] > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12345164 > > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.8.1-rc1/ > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > [4] > > > https://repository.apache.org/content/repositories/orgapacheflink-1229 > > > > [5] > > > > > > > > > > > > > > https://github.com/apache/flink/commit/11ab983ed20068dac93efe7f234ffab9abc2926e > > > > [6] https://github.com/apache/flink-web/pull/221 > > > > > > > > > >
