Hi Till, Thank you for this timely discovery! @Till Rohrmann <trohrm...@apache.org> We would start the release process after FLINK-12863 <https://issues.apache.org/jira/browse/FLINK-12863> resolved!
Best, Jincheng Till Rohrmann <trohrm...@apache.org> 于2019年6月16日周日 下午10:03写道: > Hi Jincheng, > > I just realized that we introduced a race condition with FLINK-11059. We > first need to fix this problem [1] before we can start the release process. > > [1] https://issues.apache.org/jira/browse/FLINK-12863 > > Cheers, > Till > > On Sat, Jun 15, 2019 at 3:48 PM jincheng sun <sunjincheng...@gmail.com> > wrote: > > > I am very happy to say that all the blockers and critical issues for > > released on 1.8.1 have been solved!! > > > > Great thanks to Aitozi, Yu Li, Congxian Qiu, Yun Tang, shuai.xu, JiangJie > > Qin and zhijiang for the quick fix! > > Great thanks to tzulitai, Aljoscha, Till and pnowojski for the high > > priority review! > > > > Great thanks to all of you for the help(fix or review) in promoting the > > 1.8.1 release. Thank you!!! > > > > I will prepare the first RC of release 1.8.1 as soon as possible :) > > > > Cheers, > > Jincheng > > > > jincheng sun <sunjincheng...@gmail.com> 于2019年6月14日周五 上午9:23写道: > > > > > Hi all, > > > > > > After the recent efforts of all of you, all the Issues of Blocker and > > > Critical will be completed soon! :) > > > There are only 2 issues left and they are also almost done: > > > > > > [Blocker] > > > - FLINK-12297 Work by @Aitozi <https://github.com/Aitozi> Being > > > reviewed by @Aljoscha Krettek <aljos...@apache.org>! [almost done]. > > > [Critical] > > > - FLINK-11059 Work by @shuai-xu <https://github.com/shuai-xu> Being > > > reviewed by @Till Rohrmann <trohrm...@apache.org>! [almost done] > > > > > > The detail can be found here: > > > > > > > > > https://docs.google.com/document/d/1858C7HdyDPIxxm2Rvnu4bYahq0Tr9NaY1mj7BzQi_0w/edit?usp=sharing > > > > > > Great thanks to all of you for the help(fix or review) in promoting the > > > 1.8.1 release. Thank you!!! > > > > > > I think today would finish all the Blocker and Critical issues. And > I'll > > > do the last check before preparing the RC1 of release 1.8.1. then the > > > first RC of 1.8.1 will be coming :) > > > > > > Best, > > > Jincheng > > > > > > jincheng sun <sunjincheng...@gmail.com> 于2019年6月10日周一 上午5:24写道: > > > > > >> Hi all, > > >> I am here to quickly update the progress of the issue that needs to be > > >> tracked(going well): > > >> > > >> [Blocker] > > >> - FLINK-12297 <https://issues.apache.org/jira/browse/FLINK-12297> > Work > > >> by @Aitozi <https://github.com/Aitozi> Being reviewed by @Aljoscha > > >> Krettek <aljos...@apache.org>! > > >> - FLINK-11107 <https://issues.apache.org/jira/browse/FLINK-11107> > Work > > >> by @Myasuka <https://github.com/Myasuka> Being reviewed by @Tzu-Li > > >> (Gordon) Tai <tzuli...@apache.org> > > >> > > >> [Critical] > > >> - FLINK-11059 <https://issues.apache.org/jira/browse/FLINK-11059> > Work > > >> by @shuai-xu <https://github.com/shuai-xu> Being reviewed by @Till > > >> Rohrmann <trohrm...@apache.org>! > > >> > > >> [Nice to have] > > >> - FLINK-10455 <https://issues.apache.org/jira/browse/FLINK-10455> > Work > > >> by @becketqin Need someone to volunteer review the PR > > >> > > >> The detail can be found here: > > >> > > >> > > > https://docs.google.com/document/d/1858C7HdyDPIxxm2Rvnu4bYahq0Tr9NaY1mj7BzQi_0w/edit?usp=sharing > > >> > > >> Great thanks to all of you for the help(fix or review) in promoting > the > > >> 1.8.1 release. Thank you!!! > > >> > > >> I hope to prepare the first RC of release 1.8.1 on Thursday, and > > >> FLINK-12297 <https://issues.apache.org/jira/browse/FLINK-12297>, > > >> FLINK-11107 <https://issues.apache.org/jira/browse/FLINK-11107>, > > >> FLINK-11059 <https://issues.apache.org/jira/browse/FLINK-11059> > should > > >> be merged before the RC1. > > >> If the relevant PR can't be Merged, please let me know, and we will > put > > >> more energy into solving! :) > > >> > > >> Best, > > >> Jincheng > > >> > > >> jincheng sun <sunjincheng...@gmail.com> 于2019年6月5日周三 下午5:33写道: > > >> > > >>> I am here to quickly update the progress of the issue that needs to > be > > >>> tracked(going well): > > >>> > > >>> [Blocker] > > >>> - FLINK-12296 <https://issues.apache.org/jira/browse/FLINK-12296> > > [done] > > >>> - FLINK-11987 <https://issues.apache.org/jira/browse/FLINK-11987> > > [done] > > >>> - FLINK-12297 <https://issues.apache.org/jira/browse/FLINK-12297> > > >>> Being reviewed by @Aljoscha Krettek <aljos...@apache.org>! > > >>> - FLINK-11107 <https://issues.apache.org/jira/browse/FLINK-11107> > > >>> Being reviewed by @Tzu-Li (Gordon) Tai <tzuli...@apache.org> > > >>> > > >>> [Critical] > > >>> - FLINK-10455 <https://issues.apache.org/jira/browse/FLINK-10455> > > Will > > >>> open the PR soon, great job @Jiangjie Qin > > >>> < > > https://issues.apache.org/jira/secure/ViewProfile.jspa?name=becket_qin> > > >>> ! > > >>> - FLINK-11059 <https://issues.apache.org/jira/browse/FLINK-11059> > > Being > > >>> reviewed by @Till Rohrmann <trohrm...@apache.org>! > > >>> > > >>> [Nice to have] > > >>> - FLINK-12544 <https://issues.apache.org/jira/browse/FLINK-12544> > > >>> [done] > > >>> > > >>> The detail can be found here: > > >>> > > >>> > > > https://docs.google.com/document/d/1858C7HdyDPIxxm2Rvnu4bYahq0Tr9NaY1mj7BzQi_0w/edit?usp=sharing > > >>> > > >>> Great thanks to all of you for the help(fix or review) in promoting > the > > >>> 1.8.1 release. Thank you!!! > > >>> > > >>> BTW: That's great if we can fix all of those issues, and prepare the > > >>> first RC of release 1.8.1 next week. :) > > >>> > > >>> Best, > > >>> Jincheng > > >>> > > >>> jincheng sun <sunjincheng...@gmail.com> 于2019年6月3日周一 下午1:22写道: > > >>> > > >>>> I am here to quickly update the progress of the issue that needs to > be > > >>>> tracked: > > >>>> > > >>>> [Blocker] > > >>>> - FLINK-12296 <https://issues.apache.org/jira/browse/FLINK-12296> > > >>>> [done] > > >>>> - FLINK-11987 <https://issues.apache.org/jira/browse/FLINK-11987> > > >>>> [done] > > >>>> - FLINK-12297 <https://issues.apache.org/jira/browse/FLINK-12297> > > @Aljoscha > > >>>> Krettek <aljos...@apache.org> will review the PR! > > >>>> - FLINK-11107 <https://issues.apache.org/jira/browse/FLINK-11107> > > @Tzu-Li > > >>>> (Gordon) Tai <tzuli...@apache.org> will help to review! (This is a > > new > > >>>> captur) > > >>>> > > >>>> [Critical] > > >>>> - FLINK-10455 <https://issues.apache.org/jira/browse/FLINK-10455> > > @Jiangjie > > >>>> Qin > > >>>> < > > https://issues.apache.org/jira/secure/ViewProfile.jspa?name=becket_qin> > > will > > >>>> help to take the ticket! > > >>>> - FLINK-11059 <https://issues.apache.org/jira/browse/FLINK-11059> > > Being > > >>>> reviewed by @Till Rohrmann <trohrm...@apache.org>! > > >>>> > > >>>> [Nice to have] > > >>>> - FLINK-12544 <https://issues.apache.org/jira/browse/FLINK-12544> > > Being > > >>>> reviewed by @Piotr Nowojski <pi...@ververica.com> > > >>>> > > >>>> The detail can be found here: > > >>>> > > >>>> > > > https://docs.google.com/document/d/1858C7HdyDPIxxm2Rvnu4bYahq0Tr9NaY1mj7BzQi_0w/edit?usp=sharing > > >>>> > > >>>> Great thanks to all of you for the help(fix or review) in promoting > > the > > >>>> 1.8.1 release. Thank you!!! > > >>>> > > >>>> BTW: That's great if we can fix all of those issues, and prepare the > > >>>> first RC of release 1.8.1 next week. :) > > >>>> > > >>>> Best, > > >>>> Jincheng > > >>>> > > >>>> > > >>>> Jark Wu <imj...@gmail.com> 于2019年5月30日周四 下午9:49写道: > > >>>> > > >>>>> Hi Jingcheng, > > >>>>> > > >>>>> Thanks for coordinating the work to release 1.8.1. > > >>>>> > > >>>>> +1 for 1.8.1 > > >>>>> > > >>>>> On Wed, 29 May 2019 at 19:48, Hequn Cheng <chenghe...@gmail.com> > > >>>>> wrote: > > >>>>> > > >>>>> > Hi Jincheng, > > >>>>> > > > >>>>> > Thanks for putting these together with a nice document. > > >>>>> > +1 to release 1.8.1. I think it would be nice if we can have a > new > > >>>>> release > > >>>>> > with so many fixes. > > >>>>> > > > >>>>> > Best, Hequn > > >>>>> > > > >>>>> > On Wed, May 29, 2019 at 5:25 PM jincheng sun < > > >>>>> sunjincheng...@gmail.com> > > >>>>> > wrote: > > >>>>> > > > >>>>> > > Hi all, > > >>>>> > > Thank you for your support of the release of 1.8.1. > > >>>>> > > > > >>>>> > > @Till Rohrmann <trohrm...@apache.org> Thank you very much for > > >>>>> your help > > >>>>> > > review FLINK-11059! > > >>>>> > > @Zhijiang Thank you feedback the very important bug fix. I'll > add > > >>>>> it to > > >>>>> > the > > >>>>> > > trace list! > > >>>>> > > @Tzu-Li (Gordon) Tai <tzuli...@apache.org> Great thanks for > your > > >>>>> can > > >>>>> > > kindly > > >>>>> > > help for the final stage for the flink 1.8.1 release! > > >>>>> > > @Congxian Thanks for your double check the FLINK-12296 and > update > > >>>>> the > > >>>>> > > status! > > >>>>> > > > > >>>>> > > I am here to update the progress of the issue that needs to be > > >>>>> tracked: > > >>>>> > > > > >>>>> > > [Blocker] > > >>>>> > > - FLINK-12296 < > https://issues.apache.org/jira/browse/FLINK-12296 > > > > > >>>>> [done] > > >>>>> > > - FLINK-11987 < > https://issues.apache.org/jira/browse/FLINK-11987 > > > > > >>>>> > > KafkSolution needs discussion, great thanks @Yu Li < > > >>>>> car...@gmail.com> > > >>>>> > > and @Becketqin join > > >>>>> > > in the discussion! > > >>>>> > > - FLINK-12297 < > https://issues.apache.org/jira/browse/FLINK-12297 > > > > > >>>>> > > @Aljoscha > > >>>>> > > Krettek <aljos...@apache.org> will review the PR next week! > > Great > > >>>>> > thanks > > >>>>> > > to @Aljoscha Krettek <aljos...@apache.org>! > > >>>>> > > > > >>>>> > > [Critical] > > >>>>> > > - FLINK-10455 < > https://issues.apache.org/jira/browse/FLINK-10455 > > > > > >>>>> I > > >>>>> > left a > > >>>>> > > comment on JIRA and need further discussion. (May need > > >>>>> > > - FLINK-11059 < > https://issues.apache.org/jira/browse/FLINK-11059 > > > > > >>>>> Great > > >>>>> > > thanks to @Till Rohrmann <trohrm...@apache.org> help to > review. > > >>>>> > > > > >>>>> > > [Nice to have] > > >>>>> > > - FLINK-12544 < > https://issues.apache.org/jira/browse/FLINK-12544 > > > > > >>>>> Great > > >>>>> > > thanks for the PR @Zhijiang, and need someone to volunteer > review > > >>>>> the PR! > > >>>>> > > > > >>>>> > > Furthermore, in order to better track the progress and > discussion > > >>>>> of > > >>>>> > > issues, I have compiled a simple google doc, welcome any > feedback > > >>>>> and > > >>>>> > > comments. > > >>>>> > > > > >>>>> > > > > >>>>> > > > >>>>> > > > https://docs.google.com/document/d/1858C7HdyDPIxxm2Rvnu4bYahq0Tr9NaY1mj7BzQi_0w/edit?usp=sharing > > >>>>> > > > > >>>>> > > Best, > > >>>>> > > Jincheng > > >>>>> > > > > >>>>> > > > > >>>>> > > Congxian Qiu <qcx978132...@gmail.com> 于2019年5月29日周三 上午10:47写道: > > >>>>> > > > > >>>>> > > > Hi Jincheng, > > >>>>> > > > > > >>>>> > > > Thanks for starting the discussion. > > >>>>> > > > > > >>>>> > > > +1 for 1.8.1 > > >>>>> > > > > > >>>>> > > > [Blocker] > > >>>>> > > > [FLINK-12296 Data loss silently in RocksDBStateBackend when > > more > > >>>>> than > > >>>>> > > > one] has been resolved before(master, release-1.8, > > release-1.7, > > >>>>> and > > >>>>> > > > release-1.6), but the status of the issue has not updated, > I’ve > > >>>>> closed > > >>>>> > > the > > >>>>> > > > issue now. > > >>>>> > > > > > >>>>> > > > Best Congxian > > >>>>> > > > On May 28, 2019, 17:20 +0800, Tzu-Li (Gordon) Tai < > > >>>>> tzuli...@apache.org > > >>>>> > >, > > >>>>> > > > wrote: > > >>>>> > > > > Hi Jincheng, > > >>>>> > > > > > > >>>>> > > > > Thanks for starting the discussion. > > >>>>> > > > > > > >>>>> > > > > +1 to have a 1.8.1, given there are some critical bugs > fixed > > >>>>> already > > >>>>> > > > > (including regressions such as FLINK-12301). > > >>>>> > > > > > > >>>>> > > > > I've also added > > >>>>> https://issues.apache.org/jira/browse/FLINK-11107 > > >>>>> > as a > > >>>>> > > > > potential blocker for 1.8.1. > > >>>>> > > > > Will make sure this gets merged for 1.8.1. > > >>>>> > > > > > > >>>>> > > > > I'm happy to help with you with the final steps of the > > release > > >>>>> > process. > > >>>>> > > > > > > >>>>> > > > > Cheers, > > >>>>> > > > > Gordon > > >>>>> > > > > > > >>>>> > > > > On Tue, May 28, 2019 at 5:11 PM Till Rohrmann < > > >>>>> trohrm...@apache.org> > > >>>>> > > > wrote: > > >>>>> > > > > > > >>>>> > > > > > Thanks for starting this discussion Jincheng. The 1.8.0 > > >>>>> release has > > >>>>> > > > > > happened almost 2 months ago and we have already 24 fixes > > for > > >>>>> > 1.8.1. > > >>>>> > > > Thus, > > >>>>> > > > > > I think it's time for the first bug fix release for 1.8. > > >>>>> > > > > > > > >>>>> > > > > > I will review FLINK-11059 and make sure that it will go > > into > > >>>>> 1.8.1 > > >>>>> > > > > > > > >>>>> > > > > > Cheers, > > >>>>> > > > > > Till > > >>>>> > > > > > > > >>>>> > > > > > On Tue, May 28, 2019 at 9:39 AM jincheng sun < > > >>>>> > > sunjincheng...@gmail.com > > >>>>> > > > > > > >>>>> > > > > > wrote: > > >>>>> > > > > > > > >>>>> > > > > > > Thanks for your contribution @Aitozi, I am glad to help > > >>>>> you push > > >>>>> > > this > > >>>>> > > > > > > forward ASAP. :) > > >>>>> > > > > > > > > >>>>> > > > > > > Aitozi <gjying1...@gmail.com> 于2019年5月28日周二 下午3:20写道: > > >>>>> > > > > > > > > >>>>> > > > > > > > Hi, jincheng > > >>>>> > > > > > > > > > >>>>> > > > > > > > Thanks for bringing up this discussion, I'am working > on > > >>>>> this > > >>>>> > > > blocker > > >>>>> > > > > > > issue > > >>>>> > > > > > > > ([FLINK-12297] Clean the closure for OutputTags in > > >>>>> > > PatternStream), > > >>>>> > > > but > > >>>>> > > > > > it > > >>>>> > > > > > > > has not been merged due to lack of reviewers, I think > > it > > >>>>> should > > >>>>> > > be > > >>>>> > > > > > solved > > >>>>> > > > > > > > in > > >>>>> > > > > > > > 1.8.1. > > >>>>> > > > > > > > > > >>>>> > > > > > > > > > >>>>> > > > > > > > Thanks, > > >>>>> > > > > > > > Aitozi > > >>>>> > > > > > > > > > >>>>> > > > > > > > > > >>>>> > > > > > > > > > >>>>> > > > > > > > -- > > >>>>> > > > > > > > Sent from: > > >>>>> > > > > > > > > >>>>> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/ > > >>>>> > > > > > > > > > >>>>> > > > > > > > > >>>>> > > > > > > > >>>>> > > > > > >>>>> > > > > >>>>> > > > >>>>> > > >>>> > > >