ok, agreed - I created a PR just in case another RC is needed anyway ;) This is not only about the shaded hadoop sources though...for me personally, it affects Netty - should affect anything we relocate
On 27/05/2019 11:08, Chesnay Schepler wrote: > That would've been a good workaround, but RC3 is already out. > > I wouldn't wanna delay the release any further because of something one > can work around, > especially so since this only affects people who want the shaded hadoop > sources. > For this you'd probably get by with using the original ones anyway since > we aren't relocating hadoop classes. > > On 27/05/2019 10:50, Nico Kruber wrote: >> Honestly, I'm not sure whether FLINK-12598 should be treated as a >> blocker nonetheless: Although it does not affect the usage of >> flink-shaded, it may affect Flink + Flink job developers during bug >> hunting sessions where they need to debug into the source code. In this >> scenario, you'll definitely have to handle lots of different (local) >> maven versions and without the shaded sources, you don't really have a >> nice debugging experience. >> >> @chesnay: I do understand that bumping the maven-shade-plugin version >> requires a thorough investigation - maybe as a quicker, less risky >> solution (in order not to postpone the release any longer), we could >> bump the version only for the 'shade-sources' target? >> >> >> Nico >> >> >> On 24/05/2019 06:03, jincheng sun wrote: >>> I found we should also add the `slf4j-api` as a `provided` dependency >>> for `flink-shaded-hadoop-2`. >>> >>> @Nico, Thanks for your check, and >>> the https://issues.apache.org/jira/browse/FLINK-12598 >>> <https://issues.apache.org/jira/browse/FLINK-12598> is not the blocker. >>> >>> @Chesnay, I remember where we already discussed this issue, the problems >>> caused by `provided` scope, and now, It seems nice to have added the >>> changes for the RC3! >>> >>> What do you think? @Chesnay Schepler <mailto:ches...@apache.org> >>> >>> The PR can be found here: https://github.com/apache/flink-shaded/pull/64 >>> >>> Best, >>> Jincheng >>> >>> Chesnay Schepler <ches...@apache.org <mailto:ches...@apache.org>> 于2019 >>> 年5月23日周四 下午5:29写道： >>> >>> I found another issue: >>> >>> 1. jackson is bundled twice in the uber jar. >>> 2. javax annotations are included in the slim&uber jar >>> >>> >>> As for 1), I messed up and modified the shading patterns only for >>> hadoop-uber, resulting in 2 different shading patterns for jackson. >>> (jackson is pulled into both jars separately; once explicitly in >>> shaded-hadoop, and another time in shaded-hadoop-uber as a >>> transitive >>> dependency of avro) >>> >>> I've already fixed this on master. >>> >>> 2) happened because we didn't mark findbugs as provided like in the >>> main >>> project. I'm not quite sure why we aren't doing that, but I'm >>> not too >>> bothered by this being bundled. This kind of setups where we >>> rely on >>> Flink to provide certain dependencies are a bit brittle in general. >>> >>> >>> On 23/05/2019 10:26, Chesnay Schepler wrote: >>> > Worked for me; could you try again without parallel builds? >>> > >>> > Which maven version are you using? >>> > >>> > On 23/05/2019 09:24, Nico Kruber wrote: >>> >> Thanks Jincheng, >>> >> unfortunately, I think, I found a blocker: >>> >> >>> >> -1 (non-binding) >>> >> >>> >> # not working: >>> >> - https://issues.apache.org/jira/browse/FLINK-12598 >>> >> >>> >> # ok: >>> >> - checked release notes >>> >> - verified signatures (sha512, asc) >>> >> - verified "mvn clean package -Pinclude-netty-tcnative-static" >>> >> >>> >> On 22/05/2019 07:32, Hequn Cheng wrote: >>> >>> Thank you Jincheng for the release! >>> >>> >>> >>> +1 (non-binding) >>> >>> >>> >>> - Release notes are correct. >>> >>> - Built from source archive successfully. >>> >>> - Signatures and hash are correct. >>> >>> - All artifacts(11 artifacts including flink-shaded) have been >>> >>> deployed to >>> >>> the maven central repository. >>> >>> >>> >>> One minor comment for the website pull request but I think >>> it is >>> not a >>> >>> blocker. >>> >>> >>> >>> Best, Hequn >>> >>> >>> >>> >>> >>> On Mon, May 20, 2019 at 9:20 AM jincheng sun >>> <sunjincheng...@gmail.com <mailto:sunjincheng...@gmail.com>> >>> >>> wrote: >>> >>> >>> >>>> Hi everyone, >>> >>>> >>> >>>> Please review and vote on the release candidate #2 for the >>> version >>> >>>> 7.0, as >>> >>>> follows: >>> >>>> >>> >>>> [ ] +1, Approve the release >>> >>>> [ ] -1, Do not approve the release (please provide specific >>> comments) >>> >>>> >>> >>>> The complete staging area is available for your review, which >>> >>>> includes: >>> >>>> * JIRA release notes [1], >>> >>>> * the official Apache source release to be deployed to >>> dist.apache.org <http://dist.apache.org> >>> >>>> [2], >>> >>>> which are signed with the key with fingerprint >>> >>>> 8FEA1EE9D0048C0CCC70B7573211B0703B79EA0E [3], >>> >>>> * all artifacts to be deployed to the Maven Central >>> Repository [4], >>> >>>> * source code tag "release-7.0-rc2" [5], >>> >>>> * website pull request listing the new release [6]. >>> >>>> >>> >>>> The vote will be open for at least 72 hours. It is adopted by >>> majority >>> >>>> approval, with at least 3 PMC affirmative votes. >>> >>>> >>> >>>> Thanks, >>> >>>> Jincheng >>> >>>> >>> >>>> [1] >>> >>>> >>> >>>> >>> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12345226&styleName=Html&projectId=12315522&Create=Create&atl_token=A5KQ-2QAV-T4JA-FDED%7C8ba061049bec0c5a72dc0191c47bb53a73b82cb4%7Clin >>> >>> >>> >>>> >>> >>>> [2] >>> https://dist.apache.org/repos/dist/dev/flink/flink-shaded-7.0-rc2/ >>> >>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>> >>>> [4] >>> >>>> >>> >>> https://repository.apache.org/content/repositories/orgapacheflink-1218 >>> >>>> [5] >>> https://github.com/apache/flink-shaded/tree/release-7.0-rc2 >>> >>>> [6] https://github.com/apache/flink-web/pull/209 >>> >>>> >>> > >>> > >>> > -- Nico Kruber | Solutions Architect Follow us @VervericaData Ververica -- Join Flink Forward - The Apache Flink Conference Stream Processing | Event Driven | Real Time -- Data Artisans GmbH | Invalidenstrasse 115, 10115 Berlin, Germany -- Data Artisans GmbH Registered at Amtsgericht Charlottenburg: HRB 158244 B Managing Directors: Dr. Kostas Tzoumas, Dr. Stephan Ewen
signature.asc
Description: OpenPGP digital signature
