Realistically you can't automatically infer from changes to any pom
/whether /and /what /we have to change in the notice files.
Doing this on the XML level requires a view over the entire project to
detect dependency changes in parent modules / dependency management and
packaging changes in downstream modules (like flink-dist); this would be
ridiculously complex check.
W/hether /you have to change something can be inferred from the
shade-plugin output, but not 100% reliably (for example, if a dependency
is declared to be included but everything is filtered out (yeah, that
happened)).
Theoretically it is even possible to generate the licensing files from
said output, but haven't had time yet to look into whether this is truly
possible.
On 19.03.2019 07:15, Ufuk Celebi wrote:
Hey Aljoscha,
thanks for bringing this up. I think that we should either integrate
checks for this into our CI/CD environment (using existing tools) or
add a conditional check for this into flink-bot in case a pom.xml was
modified. Otherwise it will be easy to forget in the future.
– Ufuk
On Mon, Mar 18, 2019 at 12:03 PM Aljoscha Krettek <aljos...@apache.org> wrote:
Hi All,
Please remember to add newly added dependencies to the NOTICE file of
flink-dist (which will then end up in NOTICE-binary and so on). Discovering
this late will cause delays in releases, as it is doing now.
There is a handy guide that Chesnay and Till worked on that explains licensing for
Apache projects and Flink specifically:
https://cwiki.apache.org/confluence/display/FLINK/Licensing
<https://cwiki.apache.org/confluence/display/FLINK/Licensing>
Best,
Aljoscha
