Probably I am bit late to the party, but I just started using the Flinkbot.
A big +1 for having 3 states for each step. (Pending, Approved, Rejected). Right now it is impossible to say that I checked e.g. consensus and decided that the feature requires further discussion. Best, Dawid On 21/02/2019 08:25, jincheng sun wrote: > Hi @Robert Metzger <rmetz...@apache.org> the colors of the emojis is not > very important. I think is enough if we can express the intentions clear. > +1 for alternative2, but for the corresponding pictures, if need I can look > for visual design classmates to help. what do you think? > > Best, > Jincheng > > Robert Metzger <rmetz...@apache.org> 于2019年2月19日周二 下午10:49写道： > >> Thank you all for the proposals! >> >> I've implemented most of the suggestions already, I hope to deploy it soon >> to the repo >> >> For the long label names: >> I agree with Stephan that they are pretty long at the moment. >> >> *Alternative 1:* >> review=☐☐☐☐ >> review=☐☐☐☑ >> review=☐☐☑☑ >> review=☐☑☑☑ >> review=✅ >> >> *Alternative 2:* >> >> review=description >> >> review=consensus >> >> review=architecture >> >> review=quality >> >> review=approved ✅ >> >> We could also add a ( ❓) emoji to alternative 2, but I found it looks >> ugly. >> I lean towards alternative 2. >> >> @jincheng sun <sunjincheng...@gmail.com> I could actually not find >> appropriate emojis with the colors you've proposed. The only thing that has >> a nice range of colors are hearts, but I think that's not a good fit in our >> case :) >> >> >> On Fri, Feb 15, 2019 at 12:59 PM Chesnay Schepler <ches...@apache.org> >> wrote: >> >>> The bot could check that the PR title to starts with [FLINK-X] or >>> [hotfix]. >>> >>> On 13.02.2019 10:29, Robert Metzger wrote: >>>> Hey all, >>>> >>>> the flinkbot has been active for a week now, and I hope the initial >>> hiccups >>>> have been resolved :) >>>> >>>> I wanted to start this as a permanent thread to discuss problems and >>>> improvements with the bot. >>>> >>>> *So please post here if you have questions, problems or ideas how to >>>> improve it!* >>>> >>>
signature.asc
Description: OpenPGP digital signature
