+1

- checked signatures
- locally executed build, without Hadoop, Scala 2.11
- locally executed e2e tests, looped 10 times with all attempts passing
- Staged artifacts are complete for releasing
- Changes from 1.6.2 to 1.6.3 all seem sane, IMO

Cheers,
Gordon

On 21 December 2018 at 12:49:23 AM, Till Rohrmann (trohrm...@apache.org) wrote:

+1  

- checked signatures and checksums  
- checked that no dependency changes have occurred between 1.6.2 and 1.6.3  
- build Flink from source release with Hadoop 2.8.5  
- executed all tests via `mvn verify -Dhadoop.version=2.8.5`  
- started standalone cluster and tried out WindowJoin and WordCount (batch)  
example  
- executed flink-end-to-end-tests/run-nightly-tests.sh  

Cheers,  
Till  

On Wed, Dec 19, 2018 at 9:07 PM Timo Walther <twal...@apache.org> wrote:  

> +1  
>  
> - manually checked the commit diff and could not spot any issues  
> - run mvn clean verify locally with success  
> - run a couple of e2e tests locally with success  
>  
> Thanks,  
> Timo  
>  
> Am 19.12.18 um 18:28 schrieb Aljoscha Krettek:  
> > +1  
> >  
> > - signatures/hashes are ok  
> > - verified that the log contains no suspicious output when running a  
> local cluster  
> >  
> >> On 18. Dec 2018, at 14:31, Chesnay Schepler <ches...@apache.org> wrote:  
> >>  
> >> +1  
> >>  
> >> - signatures ok  
> >> - src contains no binaries  
> >> - binary not missing any jars  
> >> - tag exists  
> >> - release notes classification/names seem appropriate  
> >> - maven artifacts not missing any jars  
> >>  
> >> On 18.12.2018 11:15, Tzu-Li (Gordon) Tai wrote:  
> >>> Hi everyone,  
> >>>  
> >>> Please review and vote on the release candidate #1 for the version  
> 1.6.3, as follows:  
> >>> [ ] +1, Approve the release  
> >>> [ ] -1, Do not approve the release (please provide specific comments)  
> >>>  
> >>>  
> >>> The complete staging area is available for your review, which includes:  
> >>> * JIRA release notes [1],  
> >>> * the official Apache source release and binary convenience releases  
> to be deployed to dist.apache.org [2], which are signed with the key with  
> fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],  
> >>> * all artifacts to be deployed to the Maven Central Repository [4],  
> >>> * source code tag “release-1.6.3-rc1” [5],  
> >>> * website pull request listing the new release and adding announcement  
> blog post [6].  
> >>>  
> >>> The vote will be open for at least 72 hours. It is adopted by majority  
> approval, with at least 3 PMC affirmative votes.  
> >>>  
> >>> Thanks,  
> >>> Gordon  
> >>>  
> >>> [1]  
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344314
>   
> >>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.6.3-rc1/  
> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS  
> >>> [4]  
> https://repository.apache.org/content/repositories/orgapacheflink-1202  
> >>> [5]  
> https://gitbox.apache.org/repos/asf?p=flink.git;a=commit;h=54e6cde28493baf35315946fd023ecbe692c95d8
>   
> >>> [6] https://github.com/apache/flink-web/pull/141  
> >>>  
> >>>  
>  
>  

Reply via email to