Sure, we don't have to include it in the release notes but can simply add a warning the 1.5 documentation. The docs are not tied to a release.
Am Fr., 21. Dez. 2018 um 09:23 Uhr schrieb Chesnay Schepler < ches...@apache.org>: > I agree to not cancel the RC. > > At the end of the day 1.5 is no longer supported. All we're doing is > releasing the things we already merged to release-1.5; > I would prefer not opening the gates for additional back-ports. > > I'm impartial to mentioning it in the release notes; why should we list > this one specifically? There are plenty of known issues, all of them > being documented in JIRA. > > On 21.12.2018 17:50, Thomas Weise wrote: > > Thanks for taking a look. Since the issue isn't a regression, my > preference > > would be to not block the release. I will keep the vote open till end of > > today for more feedback. > > > > In general what should we rely on when cutting an RC? That critical fixes > > have been backported? Otherwise it would be necessary before the RC to > > search for patches in other releases that may qualify. > > > > In this specific case the fix wasn't targeted for 1.5.x and no user seems > > to request it specifically. Should that change in the future, we can > still > > reconsider the "final release" and roll a version 1.5.7. > > > > How would others feel about mentioning this as known issue in the 1.5.6 > > release blog? > > > > Thanks, > > Thomas > > > > > > > > On Fri, Dec 21, 2018 at 12:04 AM Nico Kruber <n...@data-artisans.com> > wrote: > > > >> I know, DataStreamUtils#reinterpretAsKeyedStream() is marked > experimental, > >> but > >> would you nevertheless consider the following issue a blocker? > >> https://issues.apache.org/jira/browse/FLINK-10809 > >> It has always been present since the introduction of > >> DataStreamUtils#reinterpretAsKeyedStream() and so far only fixed for > 1.6.3 > >> and > >> 1.7. May be a good idea to include it in a "final" 1.5.x release as > well. > >> Or, > >> alternatively, put a big warning in its docs. > >> > >> > >> Nico > >> > >> On Thursday, 20 December 2018 17:18:51 CET Till Rohrmann wrote: > >>> +1 > >>> > >>> - checked signatures and checksums > >>> - checked that no dependency changes have occurred between 1.5.6 and > >> 1.5.5 > >>> - build Flink from source release with Hadoop 2.8.5 > >>> - run all tests via `mvn verify` > >>> - executed standalone cluster with multiple TaskManagers and ran batch > >> and > >>> streaming examples > >>> - Verified that web UI is working > >>> > >>> Cheers, > >>> Till > >>> > >>> On Thu, Dec 20, 2018 at 10:13 AM Chesnay Schepler <ches...@apache.org> > >>> > >>> wrote: > >>>> IIRC this exception has always been there when running without hadoop. > >>>> > >>>> On 19.12.2018 18:36, Aljoscha Krettek wrote: > >>>>> +1 > >>>>> > >>>>> - signatures/hashes are ok > >>>>> - manually checked the logs after running an example on a local > >> cluster > >>>>> There is this exception in the client log when running without > >> Hadoop in > >>>> the classpath: > >>>>> 2018-12-19 18:34:54,876 WARN org.apache.flink.client.cli.CliFrontend > >>>>> > >>>> - Could not load CLI class > >>>> > >>>> org.apache.flink.yarn.cli.FlinkYarnSessionCli. > >>>> > >>>>> java.lang.NoClassDefFoundError: > >>>> org/apache/hadoop/yarn/exceptions/YarnException > >>>> > >>>>> at java.lang.Class.forName0(Native Method) > >>>>> at java.lang.Class.forName(Class.java:264) > >>>>> at > >>>> > >> > org.apache.flink.client.cli.CliFrontend.loadCustomCommandLine(CliFrontend. > >>>> java:1218)> > >>>>> at > >>>> > >> > org.apache.flink.client.cli.CliFrontend.loadCustomCommandLines(CliFrontend > >>>> .java:1174)> > >>>>> at > >>>> org.apache.flink.client.cli.CliFrontend.main(CliFrontend.java:1100) > >>>> > >>>>> Caused by: java.lang.ClassNotFoundException: > >>>> org.apache.hadoop.yarn.exceptions.YarnException > >>>> > >>>>> at java.net.URLClassLoader.findClass(URLClassLoader.java:382) > >>>>> at java.lang.ClassLoader.loadClass(ClassLoader.java:424) > >>>>> at > >> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349) > >>>>> at java.lang.ClassLoader.loadClass(ClassLoader.java:357) > >>>>> ... 5 more > >>>>> > >>>>> This is not a problem, though it might seem strange to users. > >>>>> > >>>>>> On 18. Dec 2018, at 16:52, Chesnay Schepler <ches...@apache.org> > >> wrote: > >>>>>> +1 > >>>>>> > >>>>>> - signing key present in KEYS > >>>>>> - signatures ok > >>>>>> - src contains no binaries > >>>>>> - binary not missing any jars > >>>>>> - tag exists > >>>>>> - release notes classification/names seem appropriate > >>>>>> - maven artifacts not missing any jars > >>>>>> > >>>>>> On 18.12.2018 06:27, Thomas Weise wrote: > >>>>>>> Hi everyone, > >>>>>>> Please review and vote on the release candidate #1 for the version > >>>>>>> 1.5.6, as follows: > >>>>>>> [ ] +1, Approve the release > >>>>>>> [ ] -1, Do not approve the release (please provide specific > >> comments) > >>>>>>> The complete staging area is available for your review, which > >>>>>>> includes: > >>>>>>> * JIRA release notes [1], > >>>>>>> * the official Apache source release and binary convenience > >> releases > >>>>>>> to > >>>>>>> be deployed to dist.apache.org [2], which are signed with the key > >> with > >>>>>>> fingerprint D920A98C [3], > >>>>>>> * all artifacts to be deployed to the Maven Central Repository [4], > >>>>>>> * source code tag "release-1.5.6-rc1" [5]. > >>>>>>> > >>>>>>> The vote will be open for at least 72 hours. It is adopted by > >> majority > >>>>>>> approval, with at least 3 PMC affirmative votes. > >>>>>>> > >>>>>>> Thanks, > >>>>>>> Thomas > >>>>>>> > >>>>>>> [1] > >>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&; > >>>> version=12344315> > >>>>>>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.5.6-rc1/ > >>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>>>> [4] > >>>> > >> https://repository.apache.org/content/repositories/orgapacheflink-1199/ > >>>>>>> [5] > >>>> > >> > https://gitbox.apache.org/repos/asf?p=flink.git;a=tag;h=refs/tags/release- > > > >>> 1.5.6-rc1 > >> > >
